Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2697863002: Adjust workaround for crash bug to move up the stack. (Closed)

Created:
3 years, 10 months ago by chrishtr
Modified:
3 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust workaround for crash bug to move up the stack. TBR=pdr BUG=692083 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2697863002 Cr-Commit-Position: refs/heads/master@{#450431} Committed: https://chromium.googlesource.com/chromium/src/+/fe114a802c530e29f2d8c67caa5194699f2101b0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 2 chunks +17 lines, -11 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697863002/1
3 years, 10 months ago (2017-02-14 17:18:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fe114a802c530e29f2d8c67caa5194699f2101b0
3 years, 10 months ago (2017-02-14 19:23:19 UTC) #8
pdr.
https://codereview.chromium.org/2697863002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right): https://codereview.chromium.org/2697863002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp#newcode449 third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:449: // TODO(chrishtr): fix the underlying bug that causes this ...
3 years, 10 months ago (2017-02-14 19:26:45 UTC) #11
pdr.
3 years, 10 months ago (2017-02-14 19:26:45 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2697863002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2697863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:449: //
TODO(chrishtr): fix the underlying bug that causes this situation.
This guy got left behind

Powered by Google App Engine
This is Rietveld 408576698