Display articles in Content Suggestions

Display articles in Content Suggestions

Connect the article suggestions from the ContentSuggestionsMediator with the
suggestions UI.

BUG=686728
Review-Url: https://codereview.chromium.org/2697843003
Cr-Commit-Position: refs/heads/master@{#451589}
Committed: https://chromium.googlesource.com/chromium/src/+/fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2

[gambard, 2017-02-15 10:18:22]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org, stkhapugin@chromium.org

[gambard, 2017-02-15 10:18:22]

PTAL.
Part 2 of https://codereview.chromium.org/2691593002/

[stkhapugin, 2017-02-15 15:42:36]

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:81:
NSMutableDictionary* sectionInfoBySectionIdentifier;
Please add types

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:163:
NSInteger identifier = [self.collectionViewController.collectionViewModel
You can create an NSNumber here directly to avoid boxing below

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:166:
[self.sectionInfoBySectionIdentifier objectForKey:@(identifier)];
self.sectionInfoBySectionIdentifier[@(identifier)];

[gambard, 2017-02-16 10:11:06]

Thanks, PTAL.

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:81:
NSMutableDictionary* sectionInfoBySectionIdentifier;
On 2017/02/15 15:42:36, stkhapugin wrote:
> Please add types 

Done.

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:163:
NSInteger identifier = [self.collectionViewController.collectionViewModel
On 2017/02/15 15:42:36, stkhapugin wrote:
> You can create an NSNumber here directly to avoid boxing below

Done.

https://codereview.chromium.org/2697843003/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:166:
[self.sectionInfoBySectionIdentifier objectForKey:@(identifier)];
On 2017/02/15 15:42:36, stkhapugin wrote:
> self.sectionInfoBySectionIdentifier[@(identifier)];

Done.

[stkhapugin, 2017-02-16 10:33:23]

lgtm with comment

https://codereview.chromium.org/2697843003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2697843003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:89:
// Resets the models and cells.
What does "reset cells" mean? I'd prefer a more verbose explanation here.

[lpromero, 2017-02-17 15:58:42]

lgtm

[gambard, 2017-02-20 08:01:30]

Thanks!

https://codereview.chromium.org/2697843003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2697843003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:89:
// Resets the models and cells.
On 2017/02/16 10:33:22, stkhapugin wrote:
> What does "reset cells" mean? I'd prefer a more verbose explanation here. 

Done.

[gambard, 2017-02-20 10:01:11]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-02-20 10:01:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2697843003/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-20 10:01:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 10:20:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487584871438830,
"parent_rev": "59cb06ec17ecf2e1c2ca88040089f1a212f74612", "commit_rev":
"fb0cb90ee32bf35e4559cdb1bc3dc12b5ddc17a2"}

[commit-bot: I haz the power, 2017-02-20 10:20:49]

Description was changed from

==========
Display articles in Content Suggestions

Connect the article suggestions from the ContentSuggestionsMediator with the
suggestions UI.

BUG=686728
==========

to

==========
Display articles in Content Suggestions

Connect the article suggestions from the ContentSuggestionsMediator with the
suggestions UI.

BUG=686728

Review-Url: https://codereview.chromium.org/2697843003
Cr-Commit-Position: refs/heads/master@{#451589}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb0cb90ee32bf35e4559cdb1bc3d...
==========

[commit-bot: I haz the power, 2017-02-20 10:20:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fb0cb90ee32bf35e4559cdb1bc3d...