Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2697833004: Revert of Public Sessions - prompt the user for pageCapture requests (Closed)

Created:
3 years, 10 months ago by xlai (Olivia)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Public Sessions - prompt the user for pageCapture requests (patchset #34 id:720001 of https://codereview.chromium.org/2552203007/ ) Reason for revert: This CL is causing many PublicSessionPermissionHelperTest unit tests to fail on Linux Chromium OS ASan LSan Tests: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19549 Please fix the leaks before relanding it again. Original issue's description: > Public Sessions - prompt the user for pageCapture requests > > In Public Sessions, extensions (and apps) are force-installed by admin policy so the user does not get a chance to review the permissions for these extensions. This is not acceptable from a security/privacy standpoint, so when an extension uses the pageCapture API for the first time, we show the user a dialog where they can choose whether to allow the extension access to the API. > > BUG=689478 > BROWSERTEST=ExtensionPageCaptureApiTest.PublicSessionRequest* > UNITTEST=PublicSessionPermissionHelperTest.* > > Review-Url: https://codereview.chromium.org/2552203007 > Cr-Commit-Position: refs/heads/master@{#450383} > Committed: https://chromium.googlesource.com/chromium/src/+/309c0997afe19ab971686abf5cca1dd7fd4f7d8b TBR=atwilson@chromium.org,rdevlin.cronin@chromium.org,isandrk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689478 Review-Url: https://codereview.chromium.org/2697833004 Cr-Commit-Position: refs/heads/master@{#450483} Committed: https://chromium.googlesource.com/chromium/src/+/618b40d65c8372e95c3fb7bf848560b2a9b14a34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -847 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 1 chunk +3 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/extensions/public_session_permission_helper.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/chromeos/extensions/public_session_permission_helper.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc View 1 chunk +0 lines, -255 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 5 chunks +0 lines, -48 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_apitest.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M chrome/browser/media/public_session_media_access_handler.h View 2 chunks +31 lines, -7 lines 0 comments Download
M chrome/browser/media/public_session_media_access_handler.cc View 2 chunks +124 lines, -21 lines 0 comments Download
D chrome/browser/media/public_session_tab_capture_access_handler.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/media/public_session_tab_capture_access_handler.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/media/webrtc/public_session_tab_capture_access_handler.h View 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/media/webrtc/public_session_tab_capture_access_handler.cc View 1 chunk +143 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/page_capture/test.js View 2 chunks +1 line, -6 lines 0 comments Download
M extensions/common/permissions/api_permission_set.h View 3 chunks +0 lines, -3 lines 0 comments Download
M extensions/common/permissions/api_permission_set.cc View 3 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
xlai (Olivia)
Created Revert of Public Sessions - prompt the user for pageCapture requests
3 years, 10 months ago (2017-02-14 21:52:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697833004/1
3 years, 10 months ago (2017-02-14 21:53:28 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 21:55:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/618b40d65c8372e95c3fb7bf8485...

Powered by Google App Engine
This is Rietveld 408576698