Chromium Code Reviews
DescriptionRevert of Public Sessions - prompt the user for pageCapture requests (patchset #34 id:720001 of https://codereview.chromium.org/2552203007/ )
Reason for revert:
This CL is causing many PublicSessionPermissionHelperTest unit tests to fail on Linux Chromium OS ASan LSan Tests:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19549
Please fix the leaks before relanding it again.
Original issue's description:
> Public Sessions - prompt the user for pageCapture requests
>
> In Public Sessions, extensions (and apps) are force-installed by admin policy so the user does not get a chance to review the permissions for these extensions. This is not acceptable from a security/privacy standpoint, so when an extension uses the pageCapture API for the first time, we show the user a dialog where they can choose whether to allow the extension access to the API.
>
> BUG=689478
> BROWSERTEST=ExtensionPageCaptureApiTest.PublicSessionRequest*
> UNITTEST=PublicSessionPermissionHelperTest.*
>
> Review-Url: https://codereview.chromium.org/2552203007
> Cr-Commit-Position: refs/heads/master@{#450383}
> Committed: https://chromium.googlesource.com/chromium/src/+/309c0997afe19ab971686abf5cca1dd7fd4f7d8b
TBR=atwilson@chromium.org,rdevlin.cronin@chromium.org,isandrk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=689478
Review-Url: https://codereview.chromium.org/2697833004
Cr-Commit-Position: refs/heads/master@{#450483}
Committed: https://chromium.googlesource.com/chromium/src/+/618b40d65c8372e95c3fb7bf848560b2a9b14a34
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|