Add v8 to Blink DEPS.

Add v8 to Blink DEPS.

Now that clang-format sorts includes, v8 should be included as a user
header (using double quotes) instead of a system header (with angle
brackets). However, this means DEPS will now check for v8, so explicitly
allow it in Blink DEPS.

BUG=688155
Review-Url: https://codereview.chromium.org/2697813002
Cr-Commit-Position: refs/heads/master@{#450399}
Committed: https://chromium.googlesource.com/chromium/src/+/0dc1852220e72a4d6c62495db7481239dbbd4375

[dcheng, 2017-02-14 09:54:20]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[dcheng, 2017-02-14 09:54:23]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 09:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-14 09:58:08]

jochen@chromium.org changed reviewers:
+ haraken@chromium.org

[jochen (gone - plz use gerrit), 2017-02-14 09:58:08]

deferring to haraken@ whether we want to allow v8 at this level

[dcheng, 2017-02-14 10:07:01]

On 2017/02/14 09:58:08, jochen wrote:
> deferring to haraken@ whether we want to allow v8 at this level

wtf seems to be the only C++ source dir that doesn't include v8, so I included a
CL to explicitly block it in PS3. I don't have a strong preference between
PS2/PS3.

[dcheng, 2017-02-14 10:07:03]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 10:07:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 10:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 10:09:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dcheng, 2017-02-14 10:15:55]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[dcheng, 2017-02-14 10:16:12]

On 2017/02/14 10:07:01, dcheng wrote:
> On 2017/02/14 09:58:08, jochen wrote:
> > deferring to haraken@ whether we want to allow v8 at this level
> 
> wtf seems to be the only C++ source dir that doesn't include v8, so I included
a
> CL to explicitly block it in PS3. I don't have a strong preference between
> PS2/PS3.

Oops, fixed merge conflict.

FWIW, my personal vote is for PS2 and not worry about wtf, since it's getting
merged into platform anyway. If we're concerned about platform using v8 in the
wrong places, we could block v8 in platform as well and only whitelist it for a
few directories...

[commit-bot: I haz the power, 2017-02-14 10:16:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-14 11:04:07]

Yeah, this makes sense. The only directory where we want to avoid V8 would be
wtf/. LGTM.

Can we add -v8 to platform/wtf/DEPS?

[commit-bot: I haz the power, 2017-02-14 11:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 11:25:47]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-14 16:21:39]

On 2017/02/14 11:04:07, haraken wrote:
> Yeah, this makes sense. The only directory where we want to avoid V8 would be
> wtf/. LGTM.
> 
> Can we add -v8 to platform/wtf/DEPS?

Done.

[jochen (gone - plz use gerrit), 2017-02-14 16:23:27]

lgtm

[dcheng, 2017-02-14 16:24:08]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:24:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 17:46:05]

CQ is committing da patch.

Bot data: {"patchset_id": 70004, "attempt_start_ts": 1487089448181580,
"parent_rev": "80b7795ed45efb7fec5b2674702bef16e4c5dc5a", "commit_rev":
"0dc1852220e72a4d6c62495db7481239dbbd4375"}

[commit-bot: I haz the power, 2017-02-14 17:46:40]

Description was changed from

==========
Add v8 to Blink DEPS.

Now that clang-format sorts includes, v8 should be included as a user
header (using double quotes) instead of a system header (with angle
brackets). However, this means DEPS will now check for v8, so explicitly
allow it in Blink DEPS.

BUG=688155
==========

to

==========
Add v8 to Blink DEPS.

Now that clang-format sorts includes, v8 should be included as a user
header (using double quotes) instead of a system header (with angle
brackets). However, this means DEPS will now check for v8, so explicitly
allow it in Blink DEPS.

BUG=688155

Review-Url: https://codereview.chromium.org/2697813002
Cr-Commit-Position: refs/heads/master@{#450399}
Committed:
https://chromium.googlesource.com/chromium/src/+/0dc1852220e72a4d6c62495db748...
==========

[commit-bot: I haz the power, 2017-02-14 17:46:42]

Committed patchset #5 (id:70004) as
https://chromium.googlesource.com/chromium/src/+/0dc1852220e72a4d6c62495db748...

[Nico, 2017-02-14 17:48:19]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-14 17:48:19]

nice!