Improve test coverage for ContentFaviconDriver

content/public/test/web_contents_tester.h

Index: content/public/test/web_contents_tester.h
diff --git a/content/public/test/web_contents_tester.h b/content/public/test/web_contents_tester.h
index bb2b8b92b33dfc4a8d7aa27ad478e302b317fa53..c7657c1400ef3339edd3d607e675b75b21b6a9e6 100644
--- a/content/public/test/web_contents_tester.h
+++ b/content/public/test/web_contents_tester.h
@@ -6,9 +6,12 @@
 #define CONTENT_PUBLIC_TEST_WEB_CONTENTS_TESTER_H_
 
 #include <string>
+#include <vector>
 
 #include "content/public/browser/site_instance.h"
+#include "third_party/skia/include/core/SkBitmap.h"

[Paweł Hajdan Jr., 2017/02/21 09:44:23]

nit: Is it possible to forward declare needed types instead of adding more
#includes?

 #include "ui/base/page_transition_types.h"
+#include "ui/gfx/geometry/size.h"
 
 class GURL;
 
@@ -124,6 +127,14 @@ class WebContentsTester {
   // Returns headers that were passed in the previous SaveFrameWithHeaders(...)
   // call.
   virtual const std::string& GetSaveFrameHeaders() = 0;
+
+  // Simulates a request completion for DownloadImage(). Returns whether an
+  // actual download associated to |url| was pending.
+  virtual bool TestDidDownloadImage(
+      const GURL& url,
+      int http_status_code,
+      const std::vector<SkBitmap>& bitmaps,
+      const std::vector<gfx::Size>& original_bitmap_sizes) = 0;
 };
 
 }  // namespace content