Improve test coverage for ContentFaviconDriver

content/public/test/web_contents_tester.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_WEB_CONTENTS_TESTER_H_
 #define CONTENT_PUBLIC_TEST_WEB_CONTENTS_TESTER_H_
 
 #include <string>
+#include <vector>
 
 #include "content/public/browser/site_instance.h"
+#include "third_party/skia/include/core/SkBitmap.h"

[Paweł Hajdan Jr., 2017/02/21 09:44:23]

nit: Is it possible to forward declare needed types instead of adding more
#includes?

 #include "ui/base/page_transition_types.h"
+#include "ui/gfx/geometry/size.h"
 
 class GURL;
 
 namespace content {
 
 class BrowserContext;
 class NavigationData;
 class NavigationHandle;
 class RenderFrameHost;
 class WebContents;
@@ skipping 95 matching lines @@
                                            ui::PageTransition transition) = 0;
 
   // Sets NavgationData on |navigation_handle|.
   virtual void SetNavigationData(
       NavigationHandle* navigation_handle,
       std::unique_ptr<NavigationData> navigation_data) = 0;
 
   // Returns headers that were passed in the previous SaveFrameWithHeaders(...)
   // call.
   virtual const std::string& GetSaveFrameHeaders() = 0;
+
+  // Simulates a request completion for DownloadImage(). Returns whether an
+  // actual download associated to |url| was pending.
+  virtual bool TestDidDownloadImage(
+      const GURL& url,
+      int http_status_code,
+      const std::vector<SkBitmap>& bitmaps,
+      const std::vector<gfx::Size>& original_bitmap_sizes) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_WEB_CONTENTS_TESTER_H_