Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2697803002: [M57] Eliminate PasswordAutofillAgentConstructed() in mojo interface PasswordManagerDriver (Closed)

Created:
3 years, 10 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, Aaron Boodman, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, viettrungluu+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[M57] Eliminate PasswordAutofillAgentConstructed() in mojo interface PasswordManagerDriver PasswordAutofillAgentConstructed() is just for autofill::PasswordAutofillAgent to get logging state from browser side when PasswordAutofillAgent is created. It's useful before due to lack of pending mechanism for legacy IPCs, but now in mojo world we can achieve this goal without it. This CL lets browser side just send logging state as soon as it's ready, even at that timing point renderer process has not started or has not created PasswordAutofillAgent, the mojo call autofill::mojom::PasswordAutofillAgent::SetLoggingState() will be cached inside mojo message pipe and be executed immediately once PasswordAutofillAgent instantiates and binds itself with the pending mojo connection. This keeps exactly the same behavior with before: autofill::mojom::PasswordAutofillAgent::SetLoggingState() is always the first mojo call arriving at autofill::PasswordAutofillAgent from browser side. BUG=676814 TEST=components_unittests TBR=vabr@chromium.org,tsepez@chromium.org Review-Url: https://codereview.chromium.org/2680163006 Cr-Commit-Position: refs/heads/master@{#450171} (cherry picked from commit 2364c1b8adb850f0d1b1e29f16ecfd75679280d5) Review-Url: https://codereview.chromium.org/2697803002 . Cr-Commit-Position: refs/branch-heads/2987@{#496} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3cfb799c32b29c6c499636de1303e5fbbbdd92f5

Patch Set 1 #

Messages

Total messages: 3 (1 generated)
leonhsl(Using Gerrit)
Committed patchset #1 (id:1) manually as 3cfb799c32b29c6c499636de1303e5fbbbdd92f5 (presubmit successful).
3 years, 10 months ago (2017-02-14 09:44:31 UTC) #2
vabr (Chromium)
3 years, 10 months ago (2017-02-17 14:01:12 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698