PlzNavigate: Fix dynamic iframe back forward layout test failure

content/browser/frame_host/navigation_request.h

Index: content/browser/frame_host/navigation_request.h
diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h
index 24980b97da4696d2062a99ef41757bc9237454ce..b3cd5d90a58cc327215adfef21ce6f328c6d7e11 100644
--- a/content/browser/frame_host/navigation_request.h
+++ b/content/browser/frame_host/navigation_request.h
@@ -96,6 +96,23 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
       int current_history_list_offset,
       int current_history_list_length);
 
+  // Creates a request for a renderer-intiated history navigation. Currently
+  // only invoked for history navigations for child frames.
+  // |is_history_navigation_in_new_child| should always be true.
+  static std::unique_ptr<NavigationRequest>
+  CreateRendererInitiatedHistoryNavigation(

[clamy, 2017/02/15 16:27:55]

I don't think creating a new way to create a NavigationRequest is warranted. I'd
rather we identify which parameter is badly initialized with the existing one
and ensure it is set correctly.

[ananta, 2017/02/15 23:45:02]

Done. I added a is_user_action parameter to this function which is passed from
the renderer.

+      FrameTreeNode* frame_tree_node,
+      const GURL& dest_url,
+      const Referrer& dest_referrer,
+      const FrameNavigationEntry& frame_entry,
+      const NavigationEntryImpl& entry,
+      FrameMsg_Navigate_Type::Value navigation_type,
+      PreviewsState previews_state,
+      bool is_history_navigation_in_new_child,
+      bool has_user_gesture,
+      const base::TimeTicks& navigation_start,
+      NavigationControllerImpl* controller);
+
   ~NavigationRequest() override;
 
   // Called on the UI thread by the Navigator to start the navigation.
@@ -167,6 +184,21 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
   }
 
  private:
+  // Helper function to create a navigation request.
+  static std::unique_ptr<NavigationRequest> CreateNavigationHelper(
+      FrameTreeNode* frame_tree_node,
+      const GURL& dest_url,
+      const Referrer& dest_referrer,
+      const FrameNavigationEntry& frame_entry,
+      const NavigationEntryImpl& entry,
+      FrameMsg_Navigate_Type::Value navigation_type,
+      PreviewsState previews_state,
+      bool is_history_navigation_in_new_child,
+      bool has_user_gesture,
+      bool browser_initiated,
+      const base::TimeTicks& navigation_start,
+      NavigationControllerImpl* controller);
+
   NavigationRequest(FrameTreeNode* frame_tree_node,
                     const CommonNavigationParams& common_params,
                     const BeginNavigationParams& begin_params,