PlzNavigate: Fix dynamic iframe back forward layout test failure

content/browser/frame_host/navigation_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 
 #include <memory>
 
 #include "base/callback_forward.h"
@@ skipping 78 matching lines @@
   // should no longer be manipulated afterwards on the UI thread.
   // TODO(clamy): see if ResourceRequestBody could be un-refcounted to avoid
   // threading subtleties.
   static std::unique_ptr<NavigationRequest> CreateRendererInitiated(
       FrameTreeNode* frame_tree_node,
       const CommonNavigationParams& common_params,
       const BeginNavigationParams& begin_params,
       int current_history_list_offset,
       int current_history_list_length);
 
+  // Creates a request for a renderer-intiated history navigation. Currently
+  // only invoked for history navigations for child frames.
+  // |is_history_navigation_in_new_child| should always be true.
+  static std::unique_ptr<NavigationRequest>
+  CreateRendererInitiatedHistoryNavigation(

[clamy, 2017/02/15 16:27:55]

I don't think creating a new way to create a NavigationRequest is warranted. I'd
rather we identify which parameter is badly initialized with the existing one
and ensure it is set correctly.

[ananta, 2017/02/15 23:45:02]

Done. I added a is_user_action parameter to this function which is passed from
the renderer.

+      FrameTreeNode* frame_tree_node,
+      const GURL& dest_url,
+      const Referrer& dest_referrer,
+      const FrameNavigationEntry& frame_entry,
+      const NavigationEntryImpl& entry,
+      FrameMsg_Navigate_Type::Value navigation_type,
+      PreviewsState previews_state,
+      bool is_history_navigation_in_new_child,
+      bool has_user_gesture,
+      const base::TimeTicks& navigation_start,
+      NavigationControllerImpl* controller);
+
   ~NavigationRequest() override;
 
   // Called on the UI thread by the Navigator to start the navigation.
   void BeginNavigation();
 
   const CommonNavigationParams& common_params() const { return common_params_; }
 
   const BeginNavigationParams& begin_params() const { return begin_params_; }
 
   const RequestNavigationParams& request_params() const {
@@ skipping 51 matching lines @@
   // destroyed when a navigation is ready for commit.
   void TransferNavigationHandleOwnership(
       RenderFrameHostImpl* render_frame_host);
 
   void set_on_start_checks_complete_closure_for_testing(
       const base::Closure& closure) {
     on_start_checks_complete_closure_ = closure;
   }
 
  private:
+  // Helper function to create a navigation request.
+  static std::unique_ptr<NavigationRequest> CreateNavigationHelper(
+      FrameTreeNode* frame_tree_node,
+      const GURL& dest_url,
+      const Referrer& dest_referrer,
+      const FrameNavigationEntry& frame_entry,
+      const NavigationEntryImpl& entry,
+      FrameMsg_Navigate_Type::Value navigation_type,
+      PreviewsState previews_state,
+      bool is_history_navigation_in_new_child,
+      bool has_user_gesture,
+      bool browser_initiated,
+      const base::TimeTicks& navigation_start,
+      NavigationControllerImpl* controller);
+
   NavigationRequest(FrameTreeNode* frame_tree_node,
                     const CommonNavigationParams& common_params,
                     const BeginNavigationParams& begin_params,
                     const RequestNavigationParams& request_params,
                     bool browser_initiated,
                     bool may_transfer,
                     const FrameNavigationEntry* frame_navigation_entry,
                     const NavigationEntryImpl* navitation_entry);
 
   // NavigationURLLoaderDelegate implementation.
@@ skipping 74 matching lines @@
   std::unique_ptr<StreamHandle> body_;
 
   base::Closure on_start_checks_complete_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationRequest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_