Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: components/translate/core/browser/translate_manager.cc

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Remove unused include. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_manager.cc
diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc
index 2466bd58a040e63363f331bbd7a914b2d1b398e9..1451f741e325bdade0b9c0a85d1336e7608e89d1 100644
--- a/components/translate/core/browser/translate_manager.cc
+++ b/components/translate/core/browser/translate_manager.cc
@@ -612,4 +612,17 @@ void TranslateManager::RecordTranslateEvent(int event_type) {
translate_ranker_->AddTranslateEvent(*translate_event_);
}
+bool TranslateManager::ShouldOverrideDecision(int event_type) {
+ DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
+ if (translate_ranker_->IsDecisionOverrideEnabled()) {
+ translate_event_->add_decision_overrides(
+ static_cast<metrics::TranslateEventProto::EventType>(event_type));
+ DVLOG(3) << "Overriding decision of type: " << event_type;
+ return true;
+ } else {
+ RecordTranslateEvent(event_type);
+ return false;
+ }
+}
+
} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698