Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3076)

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Remove unused include. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.cc
diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc
index 1ce6b9d25f7b215f340e3524a75a61bfe1af14a0..e8657fcf55b343355a9600da6d61514799789a8f 100644
--- a/chrome/browser/translate/chrome_translate_client.cc
+++ b/chrome/browser/translate/chrome_translate_client.cc
@@ -226,19 +226,18 @@ void ChromeTranslateClient::ShowTranslateUI(
// In the new UI, continue offering translation after the user navigates to
// another page.
if (!base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2) &&
- !GetLanguageState().HasLanguageChanged()) {
- translate_manager_->RecordTranslateEvent(
- metrics::TranslateEventProto::MATCHES_PREVIOUS_LANGUAGE);
+ !GetLanguageState().HasLanguageChanged() &&
+ !translate_manager_->ShouldOverrideDecision(
+ metrics::TranslateEventProto::MATCHES_PREVIOUS_LANGUAGE)) {
return;
}
-
if (!triggered_from_menu &&
- GetTranslatePrefs()->IsTooOftenDenied(source_language)) {
- translate_manager_->RecordTranslateEvent(
- metrics::TranslateEventProto::LANGUAGE_DISABLED_BY_AUTO_BLACKLIST);
+ GetTranslatePrefs()->IsTooOftenDenied(source_language) &&
+ !translate_manager_->ShouldOverrideDecision(
+ metrics::TranslateEventProto::LANGUAGE_DISABLED_BY_AUTO_BLACKLIST))
return;
- }
}
+
ShowTranslateBubbleResult result = ShowBubble(step, error_type);
if (result != ShowTranslateBubbleResult::SUCCESS &&
step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {

Powered by Google App Engine
This is Rietveld 408576698