Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: components/translate/core/browser/translate_ranker_impl.h

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Make TranslateAcceptLanguages default constructor protected. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl.h
diff --git a/components/translate/core/browser/translate_ranker_impl.h b/components/translate/core/browser/translate_ranker_impl.h
index f2336331a3dbbffcef58c6e80211e8863acab637..1eaccdb2110a0e8b750fdda3fd904e894937efde 100644
--- a/components/translate/core/browser/translate_ranker_impl.h
+++ b/components/translate/core/browser/translate_ranker_impl.h
@@ -35,6 +35,7 @@ class TranslatePrefs;
extern const base::Feature kTranslateRankerQuery;
extern const base::Feature kTranslateRankerEnforcement;
extern const base::Feature kTranslateRankerLogging;
+extern const base::Feature kTranslateRankerDecisionOverride;
struct TranslateRankerFeatures {
TranslateRankerFeatures();
@@ -94,6 +95,7 @@ class TranslateRankerImpl : public TranslateRanker {
bool IsLoggingEnabled() override;
bool IsQueryEnabled() override;
bool IsEnforcementEnabled() override;
+ bool IsDecisionOverrideEnabled() override;
int GetModelVersion() const override;
bool ShouldOfferTranslation(const TranslatePrefs& translate_prefs,
const std::string& src_lang,
@@ -133,6 +135,12 @@ class TranslateRankerImpl : public TranslateRanker {
// that also enables the code paths for translate ranker querying.
bool is_enforcement_enabled_ = true;
+ // Tracks whether or not translate ranker decision override is enabled. This
+ // will override suppression heuristics and follow ranker's decision. Note
+ // that that also enables the code paths for translate ranker querying and
+ // enforcement.
+ bool is_decision_override_enabled_ = true;
+
// Saved cache of translate event protos.
std::vector<metrics::TranslateEventProto> event_cache_;

Powered by Google App Engine
This is Rietveld 408576698