Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: components/translate/core/browser/translate_ranker_impl.h

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Make TranslateAcceptLanguages default constructor protected. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_RANKER_IMPL_H_ 5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_RANKER_IMPL_H_
6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_RANKER_IMPL_H_ 6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_RANKER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 17 matching lines...) Expand all
28 28
29 namespace translate { 29 namespace translate {
30 30
31 class TranslatePrefs; 31 class TranslatePrefs;
32 32
33 // Features used to enable ranker query, enforcement and logging. Note that 33 // Features used to enable ranker query, enforcement and logging. Note that
34 // enabling enforcement implies (forces) enabling queries. 34 // enabling enforcement implies (forces) enabling queries.
35 extern const base::Feature kTranslateRankerQuery; 35 extern const base::Feature kTranslateRankerQuery;
36 extern const base::Feature kTranslateRankerEnforcement; 36 extern const base::Feature kTranslateRankerEnforcement;
37 extern const base::Feature kTranslateRankerLogging; 37 extern const base::Feature kTranslateRankerLogging;
38 extern const base::Feature kTranslateRankerDecisionOverride;
38 39
39 struct TranslateRankerFeatures { 40 struct TranslateRankerFeatures {
40 TranslateRankerFeatures(); 41 TranslateRankerFeatures();
41 42
42 TranslateRankerFeatures(int accepted, 43 TranslateRankerFeatures(int accepted,
43 int denied, 44 int denied,
44 int ignored, 45 int ignored,
45 const std::string& src, 46 const std::string& src,
46 const std::string& dst, 47 const std::string& dst,
47 const std::string& cntry, 48 const std::string& cntry,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 // from Finch. 88 // from Finch.
88 static GURL GetModelURL(); 89 static GURL GetModelURL();
89 90
90 // Over-ride the default enabled/disabled state of translate event logging. 91 // Over-ride the default enabled/disabled state of translate event logging.
91 void EnableLogging(bool value); 92 void EnableLogging(bool value);
92 93
93 // TranslateRanker... 94 // TranslateRanker...
94 bool IsLoggingEnabled() override; 95 bool IsLoggingEnabled() override;
95 bool IsQueryEnabled() override; 96 bool IsQueryEnabled() override;
96 bool IsEnforcementEnabled() override; 97 bool IsEnforcementEnabled() override;
98 bool IsDecisionOverrideEnabled() override;
97 int GetModelVersion() const override; 99 int GetModelVersion() const override;
98 bool ShouldOfferTranslation(const TranslatePrefs& translate_prefs, 100 bool ShouldOfferTranslation(const TranslatePrefs& translate_prefs,
99 const std::string& src_lang, 101 const std::string& src_lang,
100 const std::string& dst_lang) override; 102 const std::string& dst_lang) override;
101 void AddTranslateEvent( 103 void AddTranslateEvent(
102 const metrics::TranslateEventProto& translate_event) override; 104 const metrics::TranslateEventProto& translate_event) override;
103 void FlushTranslateEvents( 105 void FlushTranslateEvents(
104 std::vector<metrics::TranslateEventProto>* events) override; 106 std::vector<metrics::TranslateEventProto>* events) override;
105 107
106 void OnModelAvailable( 108 void OnModelAvailable(
(...skipping 19 matching lines...) Expand all
126 // Tracks whether or not translate event logging is enabled. 128 // Tracks whether or not translate event logging is enabled.
127 bool is_logging_enabled_ = true; 129 bool is_logging_enabled_ = true;
128 130
129 // Tracks whether or not translate ranker querying is enabled. 131 // Tracks whether or not translate ranker querying is enabled.
130 bool is_query_enabled_ = true; 132 bool is_query_enabled_ = true;
131 133
132 // Tracks whether or not translate ranker enforcement is enabled. Note that 134 // Tracks whether or not translate ranker enforcement is enabled. Note that
133 // that also enables the code paths for translate ranker querying. 135 // that also enables the code paths for translate ranker querying.
134 bool is_enforcement_enabled_ = true; 136 bool is_enforcement_enabled_ = true;
135 137
138 // Tracks whether or not translate ranker decision override is enabled. This
139 // will override suppression heuristics and follow ranker's decision. Note
140 // that that also enables the code paths for translate ranker querying and
141 // enforcement.
142 bool is_decision_override_enabled_ = true;
143
136 // Saved cache of translate event protos. 144 // Saved cache of translate event protos.
137 std::vector<metrics::TranslateEventProto> event_cache_; 145 std::vector<metrics::TranslateEventProto> event_cache_;
138 146
139 base::WeakPtrFactory<TranslateRankerImpl> weak_ptr_factory_; 147 base::WeakPtrFactory<TranslateRankerImpl> weak_ptr_factory_;
140 148
141 DISALLOW_COPY_AND_ASSIGN(TranslateRankerImpl); 149 DISALLOW_COPY_AND_ASSIGN(TranslateRankerImpl);
142 }; 150 };
143 151
144 } // namespace translate 152 } // namespace translate
145 153
146 std::ostream& operator<<(std::ostream& stream, 154 std::ostream& operator<<(std::ostream& stream,
147 const translate::TranslateRankerFeatures& features); 155 const translate::TranslateRankerFeatures& features);
148 156
149 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_RANKER_IMPL_H_ 157 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_RANKER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698