Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2697683002: Use internalized strings for v8::Template::Set shorthand. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use internalized strings for v8::Template::Set shorthand. The string will be internalized anyhow when the first object is instantiated, and since templates are eternal, the string will be eternal anyhow even if the template is never instantiated. Review-Url: https://codereview.chromium.org/2697683002 Cr-Commit-Position: refs/heads/master@{#43187} Committed: https://chromium.googlesource.com/v8/v8/+/328ad0a7c4afbb32f7d8a8752590e8cd5a54be4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
Do you know why this was kNormal before? Shared property names of many objects seem ...
3 years, 10 months ago (2017-02-13 19:52:57 UTC) #4
jochen (gone - plz use gerrit)
no idea, probably just an oversight lgtm
3 years, 10 months ago (2017-02-14 09:06:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697683002/1
3 years, 10 months ago (2017-02-14 14:07:44 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 14:10:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/328ad0a7c4afbb32f7d8a8752590e8cd5a5...

Powered by Google App Engine
This is Rietveld 408576698