Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2697623003: [css-flexbox] Don't add extra space-between space at the end (Closed)

Created:
3 years, 10 months ago by cbiesinger
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Don't add extra space-between space at the end This is a regression from https://crrev.com/2429933002. When processing the last item on a row we should not add justify-content space to the row height. I incorrectly simplified the code in that patch. Weirdly we had no tests for this :( R=eae@chromium.org BUG=690024 Review-Url: https://codereview.chromium.org/2697623003 Cr-Commit-Position: refs/heads/master@{#450364} Committed: https://chromium.googlesource.com/chromium/src/+/f63ac52a3a74c9856d6fead1b1fb26a4948b35fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/justify-content-space-between.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
cbiesinger
3 years, 10 months ago (2017-02-13 21:46:28 UTC) #1
eae
LGTM
3 years, 10 months ago (2017-02-14 15:39:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697623003/1
3 years, 10 months ago (2017-02-14 15:39:41 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:45:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f63ac52a3a74c9856d6fead1b1fb...

Powered by Google App Engine
This is Rietveld 408576698