Modify article item in ContentSuggestions

Modify article item in ContentSuggestions

This CL modifies the Article item of ContentSuggestions to allow it to point to
an article URL.

BUG=686728
Review-Url: https://codereview.chromium.org/2697573002
Cr-Commit-Position: refs/heads/master@{#449966}
Committed: https://chromium.googlesource.com/chromium/src/+/510beda2fad1d10533f1ca49a82bf0860264ccf0

[gambard, 2017-02-13 13:08:30]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-02-13 13:08:31]

PTAL.

[lpromero, 2017-02-13 13:42:40]

lgtm

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
(right):

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h:15:
// Initialize an article with a |title|, a |subtitle| and an |image|. |type| is
Update this comment.

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:72:
[faviconItem addFavicon:[UIImage imageNamed:@"bookmark_gray_star_large"]
Is the bookmark_gray_star image still used anywhere? Should it be removed if
not?

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
(right):

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h:21: //
Opens the |URL|
Add a period.

[gambard, 2017-02-13 14:32:02]

gambard@chromium.org changed reviewers:
+ marq@chromium.org

[gambard, 2017-02-13 14:32:02]

Thanks!
+marq: FYI ProtocolAlerter.

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
(right):

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h:15:
// Initialize an article with a |title|, a |subtitle| and an |image|. |type| is
On 2017/02/13 13:42:39, lpromero wrote:
> Update this comment.

Done.

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:72:
[faviconItem addFavicon:[UIImage imageNamed:@"bookmark_gray_star_large"]
On 2017/02/13 13:42:40, lpromero wrote:
> Is the bookmark_gray_star image still used anywhere? Should it be removed if
> not?

It has been removed. This is used to display something.

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
(right):

https://codereview.chromium.org/2697573002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h:21: //
Opens the |URL|
On 2017/02/13 13:42:40, lpromero wrote:
> Add a period.

Done.

[gambard, 2017-02-13 14:32:10]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-02-13 14:32:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2697573002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-13 14:32:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 14:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 14:37:48]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[gambard, 2017-02-13 14:51:19]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-02-13 14:51:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2697573002/#ps60001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-02-13 14:51:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 15:51:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486997479719610,
"parent_rev": "d83110a5ee45420581f6558715a4dc0c67263a96", "commit_rev":
"510beda2fad1d10533f1ca49a82bf0860264ccf0"}

[commit-bot: I haz the power, 2017-02-13 15:52:18]

Description was changed from

==========
Modify article item in ContentSuggestions

This CL modifies the Article item of ContentSuggestions to allow it to point to
an article URL.

BUG=686728
==========

to

==========
Modify article item in ContentSuggestions

This CL modifies the Article item of ContentSuggestions to allow it to point to
an article URL.

BUG=686728

Review-Url: https://codereview.chromium.org/2697573002
Cr-Commit-Position: refs/heads/master@{#449966}
Committed:
https://chromium.googlesource.com/chromium/src/+/510beda2fad1d10533f1ca49a82b...
==========

[commit-bot: I haz the power, 2017-02-13 15:52:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/510beda2fad1d10533f1ca49a82b...