Pass time since profile was loaded and request count on each ListAccount request to Gaia.

Pass time since profile was loaded and request count on each ListAccount request to Gaia.

This CL passes the following information on each ListAccount to Gaia:
* the count of each ListAccounts request
* the time passed since the profile was loaded and the moment the list
accounts request is started. 

This information is needed to debug channel ID mismatches observed on
Gaia for request coming from Chrome.

Sample of list accounts request with the debug information:
"https://accounts.google.com/ListAccounts?gpsia=1&source=ChromiumAccountReconcilor,counter:0,load_time_ms:327&json=standard"

BUG=633256
Review-Url: https://codereview.chromium.org/2697563002
Cr-Commit-Position: refs/heads/master@{#454873}
Committed: https://chromium.googlesource.com/chromium/src/+/b728d6759a83ac8b0967f5b993ac090017cf9fe8

[msarda, 2017-02-13 12:01:46]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 12:02:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 12:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 12:11:05]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[msarda, 2017-02-13 12:47:58]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 12:48:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 12:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 12:56:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msarda, 2017-02-13 12:58:06]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 12:58:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarda, 2017-02-13 13:02:09]

Description was changed from

==========
format


Add debug info

BUG=
==========

to

==========
Pass time since profile was loaded and request count on each ListAccount request
to Gaia.

This CL passes the following information on each ListAccount to Gaia:
* the count of each ListAccounts request
* the time passed since the profile was loaded and the moment the

This information is needed to debug channel ID mismatches observed on
Gaia for request coming from Chrome.

BUG=633256
==========

[msarda, 2017-02-13 13:03:32]

msarda@chromium.org changed reviewers:
+ vanupam@chromium.org

[msarda, 2017-02-13 13:03:33]

Vinod: Please take a look at this CL and let me know if this would help you
debug the issue you are seeing.

[commit-bot: I haz the power, 2017-02-13 13:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 13:06:22]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msarda, 2017-02-13 14:06:54]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 14:07:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 14:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 14:14:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[vanupam, 2017-02-15 03:08:28]

https://codereview.chromium.org/2697563002/diff/80001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_fetcher.cc (right):

https://codereview.chromium.org/2697563002/diff/80001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_fetcher.cc:663: extra_headers, list_accounts_gurl_,
list_accounts_gurl_ is assigned in the constructor via
ListAccountsURLWithSource(source) which lets a source=xxx url param be set.

Since this is a debugging-only change (hopefully, it will be reverted in the
near term), instead of adding new headers (which will require server side
changes to propagate into debug logs) can we append e.g. _counter_loadtime to
the source param; (The source param value has no semantics in Gaia.)

[msarda, 2017-02-15 16:03:04]

I'll take a look and see how this can information can be added to the source
parameter.

[msarda, 2017-03-01 09:37:24]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 09:37:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 09:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 09:45:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[msarda, 2017-03-01 10:26:10]

Description was changed from

==========
Pass time since profile was loaded and request count on each ListAccount request
to Gaia.

This CL passes the following information on each ListAccount to Gaia:
* the count of each ListAccounts request
* the time passed since the profile was loaded and the moment the

This information is needed to debug channel ID mismatches observed on
Gaia for request coming from Chrome.

BUG=633256
==========

to

==========
Pass time since profile was loaded and request count on each ListAccount request
to Gaia.

This CL passes the following information on each ListAccount to Gaia:
* the count of each ListAccounts request
* the time passed since the profile was loaded and the moment the list
accounts request is started. 

This information is needed to debug channel ID mismatches observed on
Gaia for request coming from Chrome.

Sample of list accounts request with the debug information:
"https://accounts.google.com/ListAccounts?gpsia=1&source=ChromiumAccountReconcilor,counter:0,load_time_ms:327&json=standard"

BUG=633256
==========

[msarda, 2017-03-01 10:26:33]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[msarda, 2017-03-01 10:26:37]

https://codereview.chromium.org/2697563002/diff/80001/google_apis/gaia/gaia_a...
File google_apis/gaia/gaia_auth_fetcher.cc (right):

https://codereview.chromium.org/2697563002/diff/80001/google_apis/gaia/gaia_a...
google_apis/gaia/gaia_auth_fetcher.cc:663: extra_headers, list_accounts_gurl_,
On 2017/02/15 03:08:28, vanupam wrote:
> list_accounts_gurl_ is assigned in the constructor via
> ListAccountsURLWithSource(source) which lets a source=xxx url param be set.
> 
> Since this is a debugging-only change (hopefully, it will be reverted in the
> near term), instead of adding new headers (which will require server side
> changes to propagate into debug logs) can we append e.g. _counter_loadtime to
> the source param; (The source param value has no semantics in Gaia.)

Done.

[msarda, 2017-03-01 10:26:44]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-01 10:26:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarda, 2017-03-01 10:26:51]

Patchset #1 (id:20001) has been deleted

[msarda, 2017-03-01 10:26:59]

Patchset #1 (id:40001) has been deleted

[msarda, 2017-03-01 10:27:15]

Patchset #1 (id:60001) has been deleted

[msarda, 2017-03-01 10:27:35]

msarda@chromium.org changed reviewers:
+ rogerta@chromium.org

[msarda, 2017-03-01 10:27:36]

Roger: Please take a look at this CL.

[commit-bot: I haz the power, 2017-03-01 10:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 10:33:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[msarda, 2017-03-01 12:03:13]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 12:03:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 12:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 12:26:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roger Tawa OOO till Jul 10th, 2017-03-01 13:42:37]

lgtm with comment below.

https://codereview.chromium.org/2697563002/diff/120001/components/signin/core...
File components/signin/core/browser/gaia_cookie_manager_service.cc (right):

https://codereview.chromium.org/2697563002/diff/120001/components/signin/core...
components/signin/core/browser/gaia_cookie_manager_service.cc:765: static
int32_t list_accounts_request_counter = 0;
Should make this a member of the class.  If you have more than one profile
loaded, all profiles will share this static value.  Unless discontinuous number
sequences don't matter.

[msarda, 2017-03-01 14:34:08]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 14:34:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarda, 2017-03-01 14:34:38]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 14:34:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarda, 2017-03-01 14:35:24]

https://codereview.chromium.org/2697563002/diff/120001/components/signin/core...
File components/signin/core/browser/gaia_cookie_manager_service.cc (right):

https://codereview.chromium.org/2697563002/diff/120001/components/signin/core...
components/signin/core/browser/gaia_cookie_manager_service.cc:765: static
int32_t list_accounts_request_counter = 0;
On 2017/03/01 13:42:37, Roger Tawa wrote:
> Should make this a member of the class.  If you have more than one profile
> loaded, all profiles will share this static value.  Unless discontinuous
number
> sequences don't matter.

Done.

[commit-bot: I haz the power, 2017-03-01 15:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 15:54:52]

Dry run: This issue passed the CQ dry run.

[Roger Tawa OOO till Jul 10th, 2017-03-01 16:41:38]

lgtm

[msarda, 2017-03-06 15:17:23]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2017-03-06 15:17:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 16:08:19]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1488813443488930,
"parent_rev": "d6ecbaf377cb296924168a77832c80ef53c75667", "commit_rev":
"b728d6759a83ac8b0967f5b993ac090017cf9fe8"}

[commit-bot: I haz the power, 2017-03-06 16:09:01]

Description was changed from

==========
Pass time since profile was loaded and request count on each ListAccount request
to Gaia.

This CL passes the following information on each ListAccount to Gaia:
* the count of each ListAccounts request
* the time passed since the profile was loaded and the moment the list
accounts request is started. 

This information is needed to debug channel ID mismatches observed on
Gaia for request coming from Chrome.

Sample of list accounts request with the debug information:
"https://accounts.google.com/ListAccounts?gpsia=1&source=ChromiumAccountReconcilor,counter:0,load_time_ms:327&json=standard"

BUG=633256
==========

to

==========
Pass time since profile was loaded and request count on each ListAccount request
to Gaia.

This CL passes the following information on each ListAccount to Gaia:
* the count of each ListAccounts request
* the time passed since the profile was loaded and the moment the list
accounts request is started. 

This information is needed to debug channel ID mismatches observed on
Gaia for request coming from Chrome.

Sample of list accounts request with the debug information:
"https://accounts.google.com/ListAccounts?gpsia=1&source=ChromiumAccountReconcilor,counter:0,load_time_ms:327&json=standard"

BUG=633256

Review-Url: https://codereview.chromium.org/2697563002
Cr-Commit-Position: refs/heads/master@{#454873}
Committed:
https://chromium.googlesource.com/chromium/src/+/b728d6759a83ac8b0967f5b993ac...
==========

[commit-bot: I haz the power, 2017-03-06 16:09:02]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b728d6759a83ac8b0967f5b993ac...