Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2697543004: WebView: prepare to depend on individual GMS services (Closed)

Created:
3 years, 10 months ago by paulmiller
Modified:
3 years, 10 months ago
Reviewers:
michaelbai, agrieve
CC:
chromium-reviews, android-webview-reviews_chromium.org, dgn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: prepare to depend on individual GMS services Remove GMS from upstream WebView (it's only needed downstream) and create a google_play_services_package variable with the upstream GMS location, so it can be overridden downstream. BUG=662166 Review-Url: https://codereview.chromium.org/2697543004 Cr-Commit-Position: refs/heads/master@{#450780} Committed: https://chromium.googlesource.com/chromium/src/+/635a45202f8cdaef30cfa4c5d4b602660e81395e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M android_webview/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
paulmiller
On 2017/02/14 02:02:06, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:agrieve@chromium.org, mailto:michaelbai@chromium.org PTAL, Michael ...
3 years, 10 months ago (2017-02-14 02:06:50 UTC) #3
agrieve
On 2017/02/14 02:06:50, paulmiller wrote: > On 2017/02/14 02:02:06, paulmiller wrote: > > mailto:paulmiller@chromium.org changed ...
3 years, 10 months ago (2017-02-14 02:11:40 UTC) #4
michaelbai
lgtm
3 years, 10 months ago (2017-02-15 02:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697543004/1
3 years, 10 months ago (2017-02-15 18:12:40 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:51:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/635a45202f8cdaef30cfa4c5d4b6...

Powered by Google App Engine
This is Rietveld 408576698