third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp - Issue 2697543003: Remove ToEventTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 2697543003: Remove ToEventTarget (Closed)

Patch Set: Code review changes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('k') | third_party/WebKit/Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

index b9f949d19cdb8d5a1ced8ce5b9d1858cf291af75..c4f7e673b535a583320e17091009ba1bfaace6d6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

@@ -35,6 +35,7 @@

#include "bindings/core/v8/V8ArrayBuffer.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8Blob.h"

+#include "bindings/core/v8/V8EventTarget.h"

#include "bindings/core/v8/V8MessagePort.h"

#include "bindings/core/v8/V8PrivateProperty.h"

#include "bindings/core/v8/V8Window.h"

@@ -110,7 +111,8 @@ void V8MessageEvent::initMessageEventMethodCustom(

v8::Local<v8::Value> dataArg = info[3];

TOSTRING_VOID(V8StringResource<>, originArg, info[4]);

TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]);

- EventTarget* sourceArg = toEventTarget(info.GetIsolate(), info[6]);

+ EventTarget* sourceArg =

+ V8EventTarget::toImplWithTypeCheck(info.GetIsolate(), info[6]);

MessagePortArray* portArray = nullptr;

const int portArrayIndex = 7;

if (!isUndefinedOrNull(info[portArrayIndex])) {