Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

Issue 2697543003: Remove ToEventTarget (Closed)
Patch Set: Code review changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
index bc29e6c242df2dba51217767ed86fef1589b2e62..66cf4f73263c8d271a2071ac553c4014add1d2f4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
@@ -30,8 +30,10 @@
#include "bindings/core/v8/V8Document.h"
+#include <memory>
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/V8EventTarget.h"
#include "bindings/core/v8/V8HTMLAllCollection.h"
#include "bindings/core/v8/V8HTMLCollection.h"
#include "bindings/core/v8/V8Node.h"
@@ -47,7 +49,6 @@
#include "wtf/PtrUtil.h"
#include "wtf/RefPtr.h"
#include "wtf/StdLibExtras.h"
-#include <memory>
namespace blink {
@@ -117,7 +118,7 @@ void V8Document::createTouchMethodPrologueCustom(
if (isUndefinedOrNull(v8Target)) {
UseCounter::count(currentExecutionContext(info.GetIsolate()),
UseCounter::DocumentCreateTouchTargetNull);
- } else if (!toEventTarget(info.GetIsolate(), v8Target)) {
+ } else if (!V8EventTarget::hasInstance(v8Target, info.GetIsolate())) {
UseCounter::count(currentExecutionContext(info.GetIsolate()),
UseCounter::DocumentCreateTouchTargetWrongType);
}

Powered by Google App Engine
This is Rietveld 408576698