[turbofan] Avoid introducing useless JSConvertReceiver during inlining.

[turbofan] Avoid introducing useless JSConvertReceiver during inlining.

In the JSInliner we shouldn't introduce JSConvertReceiver needlessly if
the input is already known to produce a receiver, i.e. if it's a
JSCreate or something like that.

BUG=v8:5267
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2697513010
Cr-Commit-Position: refs/heads/master@{#43273}
Committed: https://chromium.googlesource.com/v8/v8/+/3503ddf0dbd7d0fde050400a90c9434f030f2d4b

[Benedikt Meurer, 2017-02-17 10:06:03]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 10:06:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-02-17 10:07:46]

lgtm

https://codereview.chromium.org/2697513010/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/2697513010/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:313: if (receiver->opcode() == IrOpcode::kJSCreate)
return false;
This line is not necessary anymore, no?

[Benedikt Meurer, 2017-02-17 10:09:40]

https://codereview.chromium.org/2697513010/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/2697513010/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:313: if (receiver->opcode() == IrOpcode::kJSCreate)
return false;
On 2017/02/17 10:07:46, Jarin wrote:
> This line is not necessary anymore, no?

Done.

[Benedikt Meurer, 2017-02-17 10:09:45]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-17 10:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2697513010/#ps20001
(title: "Comment.")

[commit-bot: I haz the power, 2017-02-17 10:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 10:33:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487326185018210,
"parent_rev": "0e8798e3fa4b4149f80874e821b8771b90792200", "commit_rev":
"3503ddf0dbd7d0fde050400a90c9434f030f2d4b"}

[commit-bot: I haz the power, 2017-02-17 10:33:28]

Description was changed from

==========
[turbofan] Avoid introducing useless JSConvertReceiver during inlining.

In the JSInliner we shouldn't introduce JSConvertReceiver needlessly if
the input is already known to produce a receiver, i.e. if it's a
JSCreate or something like that.

BUG=v8:5267
R=jarin@chromium.org
==========

to

==========
[turbofan] Avoid introducing useless JSConvertReceiver during inlining.

In the JSInliner we shouldn't introduce JSConvertReceiver needlessly if
the input is already known to produce a receiver, i.e. if it's a
JSCreate or something like that.

BUG=v8:5267
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2697513010
Cr-Commit-Position: refs/heads/master@{#43273}
Committed:
https://chromium.googlesource.com/v8/v8/+/3503ddf0dbd7d0fde050400a90c9434f030...
==========

[commit-bot: I haz the power, 2017-02-17 10:33:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3503ddf0dbd7d0fde050400a90c9434f030...