Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2697473004: PPC/s390: [crankshaft] Fix Smi overflow in {HMaybeGrowElements}. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [crankshaft] Fix Smi overflow in {HMaybeGrowElements}. Port 6c12d57eada07ab019f84b2882faee6e2815a7ff Original Commit Message: This fixes the case where the index passed to {HMaybeGrowElements} used to derive the new capacity for the elements backing store does not fit into Smi range. Such an overflow would fail the capacity check and cause growing to be skipped. Subsequent keyed stores would potentially go out of bounds. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:686427 LOG=N Review-Url: https://codereview.chromium.org/2697473004 Cr-Commit-Position: refs/heads/master@{#43167} Committed: https://chromium.googlesource.com/v8/v8/+/673bbcbb9d555ee2492b860301c026caed112585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-13 18:49:03 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-13 18:50:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697473004/1
3 years, 10 months ago (2017-02-13 18:50:38 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:18:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/673bbcbb9d555ee2492b860301c026caed1...

Powered by Google App Engine
This is Rietveld 408576698