Import wpt@758b3b4cfa805067f36121333ba031e583d3a62c

Import wpt@758b3b4cfa805067f36121333ba031e583d3a62c

Using wpt-import in Chromium b83be4ca0e00b50b17619adf7f7de275455e9852.

Reason for manual import: This import is mega huge and can't be handled by the CQ properly! The patch has about 2800 files changed (mostly new files), with about 133000 inserted lines.

I'm planning to directly commit once I see that this passes the CQ and after trying to run the new tests once locally.

NOEXPORT=true
R=jsbell@chromium.org, ricea@chromium.org

Review-Url: https://codereview.chromium.org/2697453005 .
Cr-Commit-Position: refs/heads/master@{#450424}
Committed: https://chromium.googlesource.com/chromium/src/+/14f63ead450d4014818909b56a183713fd6757ca

[qyearsley, 2017-02-13 21:57:36]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:58:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-02-13 23:21:29]

Description was changed from

==========
Import wpt@758b3b4cfa805067f36121333ba031e583d3a62c

Using wpt-import in Chromium b83be4ca0e00b50b17619adf7f7de275455e9852.

NOEXPORT=true
BUG=
==========

to

==========
Import wpt@758b3b4cfa805067f36121333ba031e583d3a62c

Using wpt-import in Chromium b83be4ca0e00b50b17619adf7f7de275455e9852.

Reason for manual import: This import is mega huge and can't be handled by the
CQ properly! The patch has about 2800 files changed (mostly new files), with
about 133000 inserted lines.

I'm planning to directly commit once I see that this passes the CQ and after
trying to run the new tests once locally.

NOEXPORT=true
==========

[qyearsley, 2017-02-13 23:21:35]

qyearsley@chromium.org changed reviewers:
+ jsbell@chromium.org, tkent@chromium.org

[qyearsley, 2017-02-13 23:25:27]

Hi WPT owners!

Sorry for the spam being repeatedly CCd on import CLs for the same files over
the past few days -- it looks like this latest import is large (~2800 files), so
the CQ couldn't handle it properly.

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/html
  external/wpt/dom
  external/wpt/shadow-dom
  external/wpt/custom-elements
domenic@chromium.org:
  external/wpt/streams
estark@chromium.org:
  external/wpt/referrer-policy
foolip@chromium.org:
  external/wpt/webvtt
  external/wpt/fullscreen
jochen@chromium.org:
  external/wpt/referrer-policy
  external/wpt/subresource-integrity
jsbell@chromium.org:
  external/wpt/resources
  external/wpt/FileAPI
maksim.sisov@intel.com:
  external/wpt/webvtt
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/mixed-content
  external/wpt/subresource-integrity
ricea@chromium.org:
  external/wpt/streams
shimazu@chromium.org:
  external/wpt/service-workers
suzyh@chromium.org:
  external/wpt/web-animations
tyoshino@chromium.org:
  external/wpt/streams

[commit-bot: I haz the power, 2017-02-14 00:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:47:36]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-02-14 01:02:16]

resources/ and FileAPI/ lgtm

(mek@ is probably a better primary reviewer than I am for FileAPI/ at this
point)

[Adam Rice, 2017-02-14 02:09:23]

ricea@chromium.org changed reviewers:
+ ricea@chromium.org

[Adam Rice, 2017-02-14 02:09:30]

external/wpt/streams changes lgtm (I wrote them).

[qyearsley, 2017-02-14 05:34:35]

On 2017/02/14 at 02:09:30, ricea wrote:
> external/wpt/streams changes lgtm (I wrote them).

Alright, will now try landing directly!

[shimazu, 2017-02-14 05:35:02]

shimazu@chromium.org changed reviewers:
+ shimazu@chromium.org

[shimazu, 2017-02-14 05:35:11]

I think
external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html
which is newly introduced by this patch should fail and it should have
-expected.txt.
Looking at
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
, the test didn't run. 
I've also tried to import manually in my local and could confirm the test fails
with the following command.

$ ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master
'external/wpt/service-workers/service-worker/multi-globals'

Is it intentional behavior? Do we have an annotation to skip the test somewhere?
Sorry if I missed something!

[qyearsley, 2017-02-14 05:36:09]

On 2017/02/14 at 05:35:11, shimazu wrote:
> I think
external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html
which is newly introduced by this patch should fail and it should have
-expected.txt.
> Looking at
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
, the test didn't run. 
> I've also tried to import manually in my local and could confirm the test
fails with the following command.
> 
> $ ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master
'external/wpt/service-workers/service-worker/multi-globals'
> 
> Is it intentional behavior? Do we have an annotation to skip the test
somewhere?
> Sorry if I missed something!

Hmm, good question, will now postpone landing :-)

[qyearsley, 2017-02-14 05:42:49]

On 2017/02/14 at 05:36:09, qyearsley wrote:
> On 2017/02/14 at 05:35:11, shimazu wrote:
> > I think
external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html
which is newly introduced by this patch should fail and it should have
-expected.txt.
> > Looking at
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
, the test didn't run. 
> > I've also tried to import manually in my local and could confirm the test
fails with the following command.
> > 
> > $ ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master
'external/wpt/service-workers/service-worker/multi-globals'
> > 
> > Is it intentional behavior? Do we have an annotation to skip the test
somewhere?
> > Sorry if I missed something!
> 
> Hmm, good question, will now postpone landing :-)

I think what might have happened is: because this change is very large and the
change within MANIFEST.json was large, so it wasn't included in the patch
uploaded to Rietveld; so, when the patch was applied on the try bots,
MANIFEST.json wasn't included. The test runner uses MANIFEST.json to decide what
is test inside of WPT, and in this case, it didn't include any of the new tests
-- so there are a lot of new tests that weren't run. If this got committed now,
there would probably be hundreds of failures. Will look into this tomorrow.

[suzyh_UTC10 (ex-contributor), 2017-02-14 05:46:06]

On 2017/02/14 at 05:36:09, qyearsley wrote:
> On 2017/02/14 at 05:35:11, shimazu wrote:
> > I think
external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html
which is newly introduced by this patch should fail and it should have
-expected.txt.
> > Looking at
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
, the test didn't run. 
> > I've also tried to import manually in my local and could confirm the test
fails with the following command.
> > 
> > $ ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master
'external/wpt/service-workers/service-worker/multi-globals'
> > 
> > Is it intentional behavior? Do we have an annotation to skip the test
somewhere?
> > Sorry if I missed something!
> 
> Hmm, good question, will now postpone landing :-)

Hmm... I haven't done a full check, but I think at least one of the new
web-animations tests has also been skipped.

[qyearsley, 2017-02-14 15:13:52]

On 2017/02/14 at 05:46:06, suzyh wrote:
> On 2017/02/14 at 05:36:09, qyearsley wrote:
> > On 2017/02/14 at 05:35:11, shimazu wrote:
> > > I think
external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html
which is newly introduced by this patch should fail and it should have
-expected.txt.
> > > Looking at
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
, the test didn't run. 
> > > I've also tried to import manually in my local and could confirm the test
fails with the following command.
> > > 
> > > $ ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master
'external/wpt/service-workers/service-worker/multi-globals'
> > > 
> > > Is it intentional behavior? Do we have an annotation to skip the test
somewhere?
> > > Sorry if I missed something!
> > 
> > Hmm, good question, will now postpone landing :-)
> 
> Hmm... I haven't done a full check, but I think at least one of the new
web-animations tests has also been skipped.

Yeah, I think that likely all of the new tests have been skipped.

What I plan to do for this CL is to land it with Skip expectations in
TestExpectatoins, and then follow up today with a manual
rebaseline/update-expectations CL.

[qyearsley, 2017-02-14 17:14:25]

On 2017/02/14 at 15:13:52, qyearsley wrote:
> On 2017/02/14 at 05:46:06, suzyh wrote:
> > On 2017/02/14 at 05:36:09, qyearsley wrote:
> > > On 2017/02/14 at 05:35:11, shimazu wrote:
> > > > I think
external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html
which is newly introduced by this patch should fail and it should have
-expected.txt.
> > > > Looking at
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
, the test didn't run. 
> > > > I've also tried to import manually in my local and could confirm the
test fails with the following command.
> > > > 
> > > > $ ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master
'external/wpt/service-workers/service-worker/multi-globals'
> > > > 
> > > > Is it intentional behavior? Do we have an annotation to skip the test
somewhere?
> > > > Sorry if I missed something!
> > > 
> > > Hmm, good question, will now postpone landing :-)
> > 
> > Hmm... I haven't done a full check, but I think at least one of the new
web-animations tests has also been skipped.
> 
> Yeah, I think that likely all of the new tests have been skipped.
> 
> What I plan to do for this CL is to land it with Skip expectations in
TestExpectatoins, and then follow up today with a manual
rebaseline/update-expectations CL.

Now trying to land; see http://crbug.com/692105 for follow-up CLs.

[qyearsley, 2017-02-14 18:55:01]

Description was changed from

==========
Import wpt@758b3b4cfa805067f36121333ba031e583d3a62c

Using wpt-import in Chromium b83be4ca0e00b50b17619adf7f7de275455e9852.

Reason for manual import: This import is mega huge and can't be handled by the
CQ properly! The patch has about 2800 files changed (mostly new files), with
about 133000 inserted lines.

I'm planning to directly commit once I see that this passes the CQ and after
trying to run the new tests once locally.

NOEXPORT=true
==========

to

==========
Import wpt@758b3b4cfa805067f36121333ba031e583d3a62c

Using wpt-import in Chromium b83be4ca0e00b50b17619adf7f7de275455e9852.

Reason for manual import: This import is mega huge and can't be handled by the
CQ properly! The patch has about 2800 files changed (mostly new files), with
about 133000 inserted lines.

I'm planning to directly commit once I see that this passes the CQ and after
trying to run the new tests once locally.

NOEXPORT=true
R=jsbell@chromium.org, ricea@chromium.org

Review-Url: https://codereview.chromium.org/2697453005 .
Cr-Commit-Position: refs/heads/master@{#450424}
Committed:
https://chromium.googlesource.com/chromium/src/+/14f63ead450d4014818909b56a18...
==========

[qyearsley, 2017-02-14 18:55:09]

Committed patchset #2 (id:10001) manually as
14f63ead450d4014818909b56a183713fd6757ca (presubmit successful).

[qyearsley, 2017-02-14 19:19:05]

On 2017/02/14 at 18:55:09, qyearsley wrote:
> Committed patchset #2 (id:10001) manually as
14f63ead450d4014818909b56a183713fd6757ca (presubmit successful).

Note to sheriff: If this change causes any new layout test failures (I hope it
doesn't!) it may be easiest to handle by adding a Failure expectation in
LayoutTests/TestExpectations (associated with bug 692105) and I will clean it up
as soon as I can!