Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2697383003: Remove SafePointScopes in HeapTest.cpp (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SafePointScopes in HeapTest.cpp Currently SafePointScope is used for two purposes: a) Declare that the thread is not operating on the oilpan heap and let another thread start a GC. b) Record the stack end and all registers before starting a GC. Now that we have the per-thread heap, a) is not needed. b) is still needed though. The SafePointScopes removed in this CL is a). BUG=671856 Review-Url: https://codereview.chromium.org/2697383003 Cr-Commit-Position: refs/heads/master@{#451289} Committed: https://chromium.googlesource.com/chromium/src/+/580f0df2c038eb1e575b169ed6491e9cbe92bc11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 10 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-17 11:20:47 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-17 12:00:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697383003/1
3 years, 10 months ago (2017-02-17 12:08:30 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 12:47:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/580f0df2c038eb1e575b169ed649...

Powered by Google App Engine
This is Rietveld 408576698