Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2697363002: cros: Fix various small issues with cast tray entry. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

cros: Fix various small issues with cast tray entry. 673023: Do not show TrayCast active state until we have media router information to prevent short visual glitch where we are "Casting to unknown receiver". 683908: Only show local routes 671094: Better accessibility label for Stop casting button. BUG=673023, 683908, 671094 Review-Url: https://codereview.chromium.org/2656003006 Cr-Commit-Position: refs/heads/master@{#447045} (cherry picked from commit 461840ed16b4e886966d5bc44558668f8df382b7) Review-Url: https://codereview.chromium.org/2697363002 . Cr-Commit-Position: refs/branch-heads/2987@{#553} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1dbca8ec13dcf78b1c689018527315856c2b0a95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -24 lines) Patch
M ash/ash_strings.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/cast/tray_cast.cc View 3 chunks +17 lines, -11 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 2 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
3 years, 10 months ago (2017-02-16 19:13:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dbca8ec13dcf78b1c689018527315856c2b0a95.

Powered by Google App Engine
This is Rietveld 408576698