Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2697353003: cc: Make ScopedResource constructor public, use MakeUnique to construct (Closed)

Created:
3 years, 10 months ago by danakj
Modified:
3 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make ScopedResource constructor public, use MakeUnique to construct R=enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2697353003 Cr-Commit-Position: refs/heads/master@{#451176} Committed: https://chromium.googlesource.com/chromium/src/+/2dd2a62af5e387241b5bde49814f6155ec739941

Patch Set 1 #

Patch Set 2 : construct: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -27 lines) Patch
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/resources/scoped_resource.h View 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/scoped_resource_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
danakj
3 years, 10 months ago (2017-02-16 19:22:55 UTC) #2
enne (OOO)
lgtm
3 years, 10 months ago (2017-02-16 19:25:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697353003/1
3 years, 10 months ago (2017-02-16 19:27:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/171744)
3 years, 10 months ago (2017-02-16 19:57:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697353003/20001
3 years, 10 months ago (2017-02-16 23:11:23 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 02:10:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2dd2a62af5e387241b5bde49814f...

Powered by Google App Engine
This is Rietveld 408576698