Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2697213002: Do not guess UTF8 encoding (Closed)

Created:
3 years, 10 months ago by Jinsuk Kim
Modified:
3 years, 10 months ago
Reviewers:
tkent, sky
CC:
blink-reviews, chromium-reviews, kinuko+watch, aelias_OOO_until_Jul13
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not guess UTF8 encoding Makes the text encoding detector return false if the detected encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers to neglect proper encoding labelling and rely on browser-side encoding detection. This CL helps prevent that. BUG=691985 Review-Url: https://codereview.chromium.org/2697213002 Cr-Commit-Position: refs/heads/master@{#451194} Committed: https://chromium.googlesource.com/chromium/src/+/89967f02f2402870acb8322ad50c391b3a0971e7

Patch Set 1 #

Patch Set 2 : removed utf8 detection test/files #

Patch Set 3 : updated some webkit layout test html's #

Patch Set 4 : webkit layout htmls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M chrome/browser/browser_encoding_browsertest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/encoding_tests/auto_detect/UTF-8_with_no_encoding_specified.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/encoding_tests/auto_detect/expected_results/expected_UTF-8_saved_from_no_encoding_specified.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/move-cursor-to-misspelled-word.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spelling-insert-newline-between-multi-word-misspelling.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing-html-fragments/the-input-byte-stream-015.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-vertical.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-vertical-expected.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-break-all-in-span.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-break-all-in-span-expected.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/invalid-protocol.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/ellipsis-at-edge-of-ltr-text-in-rtl-flow.html View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetectorTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
Jinsuk Kim
3 years, 10 months ago (2017-02-16 00:50:12 UTC) #3
tkent
lgtm
3 years, 10 months ago (2017-02-16 00:51:09 UTC) #5
Jinsuk Kim
Some Webkit tests files didn't have UTF8 label, and got affected by the change. Added ...
3 years, 10 months ago (2017-02-16 11:35:55 UTC) #17
sky
On 2017/02/16 11:35:55, Jinsuk Kim wrote: > Some Webkit tests files didn't have UTF8 label, ...
3 years, 10 months ago (2017-02-16 17:25:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697213002/60001
3 years, 10 months ago (2017-02-16 23:05:32 UTC) #21
Jinsuk Kim
On 2017/02/16 17:25:00, sky wrote: > On 2017/02/16 11:35:55, Jinsuk Kim wrote: > > Some ...
3 years, 10 months ago (2017-02-17 00:16:40 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/366701)
3 years, 10 months ago (2017-02-17 00:55:18 UTC) #24
sky
LGTM
3 years, 10 months ago (2017-02-17 00:58:43 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697213002/60001
3 years, 10 months ago (2017-02-17 01:10:43 UTC) #27
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 02:39:25 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/89967f02f2402870acb8322ad50c...

Powered by Google App Engine
This is Rietveld 408576698