Chromium Code Reviews Chromium Code Reviews
Issue
2697143003:
Revert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of https://codereview.chr… (Closed)
DescriptionRevert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of https://codereview.chromium.org/2669323002/ )
Reason for revert:
Appears to be the root cause of crbug.com/692509 (renderer crashes in RenderThreadImpl::OnProcessPurgeAndSuspend) - although the timeline doesn't match up, the change to RenderThreadImpl appears incorrect by inspection (see my comment in the original CL).
Original issue's description:
> Add ChildMemoryCoordinator::PurgeMemory()
>
> In crrev.com/2655083003 we added OnPurgeMemory() to
> MemoryCoordinatorClient and we are moving purging logic from
> OnMemoryStateChange() to OnPurgeMemory(). To make this transition easy,
> this CL adds PurgeMemory() to ChildMemoryCoordinator. This method calls
> both OnPurgeMemory() and OnMemoryStateChange(SUSPENDED). After purging
> logic in all clients move to OnPurgeMemory(), we can remove
> OnMemoryStateChange() call.
>
> BUG=684287
>
> Review-Url: https://codereview.chromium.org/2669323002
> Cr-Commit-Position: refs/heads/master@{#448475}
> Committed: https://chromium.googlesource.com/chromium/src/+/110841cafec3a76ab7446dc7c59107572a2fc68f
NOTRY=true
TBR=tasak@google.com,jam@chromium.org,haraken@chromium.org,bashi@chromium.org
BUG=684287
Review-Url: https://codereview.chromium.org/2693223003
Cr-Commit-Position: refs/heads/master@{#450859}
(cherry picked from commit c80d2d2b0fcceac67a16bf6ffb516ba5c0023230)
Review-Url: https://codereview.chromium.org/2697143003 .
Cr-Commit-Position: refs/branch-heads/3013@{#3}
Cr-Branched-From: 1645e63d771e2ee049d465ce70bca163fd9f5bcc-refs/heads/master@{#450530}
Committed: https://chromium.googlesource.com/chromium/src/+/c1145a7dc82f06717a15b35f36442f3b1e5b6b49
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||
