third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl - Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl

Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor. (Closed)

Patch Set: Use ScriptState Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl

index 3df7b874b152a3dbfcdf6826fe1da8d975abb93a..9b5c78483a9d0cd13772c5599b95aff0e8407ac1 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl

@@ -7,7 +7,7 @@

[

RuntimeEnabled=PaymentRequest,

Constructor(DOMString type, optional PaymentRequestUpdateEventInit eventInitDict),

- ConstructorCallWith=ExecutionContext

+ ConstructorCallWith=ScriptState

please use gerrit instead 2017/02/19 18:53:02 Docs say that CallWith=ExecutionContext is depreca

Marijn Kruisselbrink 2017/02/21 19:08:56 Yep, seems that way. Although I'm very confused no

] interface PaymentRequestUpdateEvent : Event {

[CallWith=ScriptState,RaisesException] void updateWith(Promise<PaymentDetails> d);

};