third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl - Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl

Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor. (Closed)

Patch Set: Use ScriptState Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/browser-payment-api/#idl-def-paymentrequestupdateevent	5 // https://w3c.github.io/browser-payment-api/#idl-def-paymentrequestupdateevent

6	6

7 [	7 [

8 RuntimeEnabled=PaymentRequest,	8 RuntimeEnabled=PaymentRequest,

9 Constructor(DOMString type, optional PaymentRequestUpdateEventInit eventInit Dict),	9 Constructor(DOMString type, optional PaymentRequestUpdateEventInit eventInit Dict),

10 ConstructorCallWith=ExecutionContext	10 ConstructorCallWith=ScriptState
	please use gerrit instead 2017/02/19 18:53:02 Docs say that CallWith=ExecutionContext is depreca Docs say that CallWith=ExecutionContext is deprecated, right? Marijn Kruisselbrink 2017/02/21 19:08:56 Yep, seems that way. Although I'm very confused no Show quoted text On 2017/02/19 at 18:53:02, rouslan wrote: > Docs say that CallWith=ExecutionContext is deprecated, right? Yep, seems that way. Although I'm very confused now. haraken@: in the same BUG that is linked from the CL that updated the documentation to mark CallWith=ExecutionContext deprecated, you landed another CL that replaced a whole bunch of CallWith=ScriptState with CallWith=ExecutionContext, specifically in the payments code? Did you change your mind in the two hours between landing those CLs?
11 ] interface PaymentRequestUpdateEvent : Event {	11 ] interface PaymentRequestUpdateEvent : Event {

12 [CallWith=ScriptState,RaisesException] void updateWith(Promise<PaymentDetail s> d);	12 [CallWith=ScriptState,RaisesException] void updateWith(Promise<PaymentDetail s> d);

13 };	13 };

OLD	NEW