Fix of "login is not defined" error in OOBE

chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index cf023763f334e81d2a5efb3dcdeb3b0cd3ce2f4e..70a88e012bd60d76f87c6121cf1ee06d051c90bc 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -1128,7 +1128,8 @@ void SigninScreenHandler::SuspendDone(const base::TimeDelta& sleep_duration) {
 
 void SigninScreenHandler::OnTouchViewToggled(bool enabled) {
   touch_view_enabled_ = enabled;
-  CallJS("login.AccountPickerScreen.setTouchViewState", enabled);
+  GetOobeUI()->CallJSOrDefer("login.AccountPickerScreen.setTouchViewState",

[Alexander Alekseev, 2017/02/21 23:46:49]

GetOobeUI() is a member of BaseScreenHandler.

This means that we can rename current OobeUI::CallJSOrDefer() to
OobeUI::CallJSOrDeferImpl(), and implement BaseScreenHandler::CallJSOrDefer()
that will be drop-down replacement for previous CallJSOrDefer() .

WDYT?

[Wenzhao (Colin) Zang, 2017/02/22 02:53:34]

If BaseScreenHandler calls CallJSOrDeferImpl() in OobeUI, which then calls
CallJS() in BaseScreenHandler, we will have a circular dependency between the
two classes.

Maybe we should move CallJS() to OobeUI too (but that requires changing all the
calls to OobeUI::CallJS()), or put all the relevant pieces of CallJS() to a
separate file, and add wrappers around it in BaseScreenHandler and OobeUI
respectively (But it will again result in lots of codes because all the
templates need to be repeated).

+                             this, enabled);
 }
 
 bool SigninScreenHandler::ShouldLoadGaia() const {