Fix of "login is not defined" error in OOBE

chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 1110 matching lines @@
 
 void SigninScreenHandler::SuspendDone(const base::TimeDelta& sleep_duration) {
   for (user_manager::User* user :
        user_manager::UserManager::Get()->GetUnlockUsers()) {
     HidePinKeyboardIfNeeded(user->GetAccountId());
   }
 }
 
 void SigninScreenHandler::OnTouchViewToggled(bool enabled) {
   touch_view_enabled_ = enabled;
-  CallJS("login.AccountPickerScreen.setTouchViewState", enabled);
+  GetOobeUI()->CallJSOrDefer("login.AccountPickerScreen.setTouchViewState",

[Alexander Alekseev, 2017/02/21 23:46:49]

GetOobeUI() is a member of BaseScreenHandler.

This means that we can rename current OobeUI::CallJSOrDefer() to
OobeUI::CallJSOrDeferImpl(), and implement BaseScreenHandler::CallJSOrDefer()
that will be drop-down replacement for previous CallJSOrDefer() .

WDYT?

[Wenzhao (Colin) Zang, 2017/02/22 02:53:34]

If BaseScreenHandler calls CallJSOrDeferImpl() in OobeUI, which then calls
CallJS() in BaseScreenHandler, we will have a circular dependency between the
two classes.

Maybe we should move CallJS() to OobeUI too (but that requires changing all the
calls to OobeUI::CallJS()), or put all the relevant pieces of CallJS() to a
separate file, and add wrappers around it in BaseScreenHandler and OobeUI
respectively (But it will again result in lots of codes because all the
templates need to be repeated).

+                             this, enabled);
 }
 
 bool SigninScreenHandler::ShouldLoadGaia() const {
   // Fetching of the extension is not started before account picker page is
   // loaded because it can affect the loading speed.
   // Do not load the extension for the screen locker, see crosbug.com/25018.
   return !ScreenLocker::default_screen_locker() &&
          is_account_picker_showing_first_time_;
 }
 
@@ skipping 495 matching lines @@
   rate.initial_delay_in_ms = auto_repeat_delay;
   rate.repeat_interval_in_ms = auto_repeat_interval;
   input_method::InputMethodManager::Get()
       ->GetImeKeyboard()
       ->SetAutoRepeatEnabled(true);
   input_method::InputMethodManager::Get()->GetImeKeyboard()->SetAutoRepeatRate(
       rate);
 }
 
 }  // namespace chromeos