Makes Shell::SetDisplayWorkAreaInsets() call to WmShell

Makes Shell::SetDisplayWorkAreaInsets() call to WmShell

This way code using Shell just works for mash.

BUG=693114
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2697043004
Cr-Commit-Position: refs/heads/master@{#451039}
Committed: https://chromium.googlesource.com/chromium/src/+/92f5587fc88654201efb2e6658812c2aec5a7c2f

[sky, 2017-02-16 17:53:35]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 17:54:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-02-16 18:34:49]

lgtm with q and aside

https://codereview.chromium.org/2697043004/diff/1/ash/aura/wm_shell_aura.cc
File ash/aura/wm_shell_aura.cc (right):

https://codereview.chromium.org/2697043004/diff/1/ash/aura/wm_shell_aura.cc#n...
ash/aura/wm_shell_aura.cc:145:
->UpdateWorkAreaOfDisplayNearestWindow(window->aura_window(), insets);
q: what's your advice on using WmWindow::aura_window() vs
WmWindow::GetAuraWindow()? Do you know that this will be non-null, or will we
just handle crashes as they come up? (I'm doing lots of WmWindow<->aura::Window
conversion in my WIP CL to eliminate WmWindowObserver, not sure I'll have a
reasonable CL to eliminate it in one fell swoop)

https://codereview.chromium.org/2697043004/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2697043004/diff/1/ash/shell.cc#newcode277
ash/shell.cc:277: wm_shell_->SetDisplayWorkAreaInsets(WmWindow::Get(contains),
insets);
It's a bit odd to do Shell->WmShell->Shell, but it's temporary...

[commit-bot: I haz the power, 2017-02-16 18:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:37:59]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-16 18:42:20]

https://codereview.chromium.org/2697043004/diff/1/ash/aura/wm_shell_aura.cc
File ash/aura/wm_shell_aura.cc (right):

https://codereview.chromium.org/2697043004/diff/1/ash/aura/wm_shell_aura.cc#n...
ash/aura/wm_shell_aura.cc:145:
->UpdateWorkAreaOfDisplayNearestWindow(window->aura_window(), insets);
On 2017/02/16 18:34:49, msw wrote:
> q: what's your advice on using WmWindow::aura_window() vs
> WmWindow::GetAuraWindow()?

Get rid of WmWindow! ;)

Good question. I think it depends upon the code. If the code may pass in null,
then you are right that WmWindow::GetAuraWindow() is safer.

> Do you know that this will be non-null, 

The down stream code
(WindowTreeHostManager::UpdateworkAreaOfDisplayNearestWindow()) crashes on null,
so it seems fair to assume non-null here.

> or will we
> just handle crashes as they come up? (I'm doing lots of
WmWindow<->aura::Window
> conversion in my WIP CL to eliminate WmWindowObserver, not sure I'll have a
> reasonable CL to eliminate it in one fell swoop)

https://codereview.chromium.org/2697043004/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2697043004/diff/1/ash/shell.cc#newcode277
ash/shell.cc:277: wm_shell_->SetDisplayWorkAreaInsets(WmWindow::Get(contains),
insets);
On 2017/02/16 18:34:49, msw wrote:
> It's a bit odd to do Shell->WmShell->Shell, but it's temporary...

Acknowledged.

[sky, 2017-02-16 18:42:25]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:43:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:13:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487270545960780, "parent_rev":
"2855a03b33c6690f37f364168a2ec23cb4002b53", "commit_rev":
"92f5587fc88654201efb2e6658812c2aec5a7c2f"}

[commit-bot: I haz the power, 2017-02-16 19:13:44]

Description was changed from

==========
Makes Shell::SetDisplayWorkAreaInsets() call to WmShell

This way code using Shell just works for mash.

BUG=693114
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Makes Shell::SetDisplayWorkAreaInsets() call to WmShell

This way code using Shell just works for mash.

BUG=693114
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2697043004
Cr-Commit-Position: refs/heads/master@{#451039}
Committed:
https://chromium.googlesource.com/chromium/src/+/92f5587fc88654201efb2e665881...
==========

[commit-bot: I haz the power, 2017-02-16 19:13:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92f5587fc88654201efb2e665881...