Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2697033006: Switching MediaStreamManager from using AudioManager to AudioSystem (Closed)

Created:
3 years, 10 months ago by o1ka
Modified:
3 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, Max Morin, ossu-chromium, DaleCurtis, audio-mojo-cl_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching MediaStreamManager from using AudioManager to AudioSystem MediaDevicesManager and AudioInputDeviceManager will be addressed in separate follow-up CLs, to keep it simpler. BUG=672468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2697033006 Cr-Commit-Position: refs/heads/master@{#457807} Committed: https://chromium.googlesource.com/chromium/src/+/e309da24090a50c7252333bc2c844d7089bf17ce

Patch Set 1 #

Patch Set 2 : weak pointers removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -41 lines) Patch
M content/browser/browser_main_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 3 chunks +3 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 7 chunks +14 lines, -20 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_unittest.cc View 1 4 chunks +5 lines, -1 line 0 comments Download
M media/audio/audio_system.h View 3 chunks +9 lines, -1 line 0 comments Download
M media/audio/audio_system_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
o1ka
guidou@ - PTAL (the CL it's based on got reverted, so the bots are failing; ...
3 years, 10 months ago (2017-02-16 15:27:21 UTC) #8
o1ka
On 2017/02/16 15:27:21, o1ka wrote: > guidou@ - PTAL > (the CL it's based on ...
3 years, 10 months ago (2017-02-16 15:30:12 UTC) #9
o1ka
guidou@ - PTAL now?
3 years, 9 months ago (2017-03-17 14:13:22 UTC) #13
Guido Urdaneta
lgtm
3 years, 9 months ago (2017-03-17 14:25:10 UTC) #14
o1ka
tommi@: could you RS media/audio? avi@: could you RS content/browser/browser_main_loop.cc? Thanks!
3 years, 9 months ago (2017-03-17 14:34:36 UTC) #15
o1ka
(and now with updated reviewer list) tommi@: could you RS media/audio? avi@: could you RS ...
3 years, 9 months ago (2017-03-17 14:35:55 UTC) #18
Avi (use Gerrit)
lgtm stamp
3 years, 9 months ago (2017-03-17 16:36:45 UTC) #19
tommi (sloooow) - chröme
Rs lgtm
3 years, 9 months ago (2017-03-17 16:44:51 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697033006/20001
3 years, 9 months ago (2017-03-17 17:31:18 UTC) #24
o1ka
Thanks everybody!
3 years, 9 months ago (2017-03-17 17:31:29 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 17:39:05 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e309da24090a50c7252333bc2c84...

Powered by Google App Engine
This is Rietveld 408576698