Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2697033003: [Chromecast] Fix IsSupportedVideoConfig() on Android. (Closed)

Created:
3 years, 10 months ago by AndyWu
Modified:
3 years, 10 months ago
Reviewers:
xhwang, halliwell, Simeon
CC:
chromium-reviews, lcwu+watch_chromium.org, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, agrieve+watch_chromium.org, alokp+watch_chromium.org, mlamouri+watch-media_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix IsSupportedVideoConfig() on Android. Since Android does not explicitly list all supported levels, we should check whether the level is smaller or equal to supported levels. BUG=Internal b/34175462 b/34808220 b/35257976 TEST=base_unittests, media_unittests, cast_media_unittests Review-Url: https://codereview.chromium.org/2697033003 Cr-Commit-Position: refs/heads/master@{#450979} Committed: https://chromium.googlesource.com/chromium/src/+/33bb85e3541ce2b72da83dcd474d8ddea7f2cad6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromecast/media/base/supported_codec_profile_levels_memo.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/CodecProfileLevelList.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
AndyWu
3 years, 10 months ago (2017-02-15 20:19:50 UTC) #4
halliwell
On 2017/02/15 20:19:50, AndyWu wrote: lgtm
3 years, 10 months ago (2017-02-15 20:26:20 UTC) #5
Simeon
lgtm
3 years, 10 months ago (2017-02-15 22:24:37 UTC) #6
xhwang
lgtm
3 years, 10 months ago (2017-02-15 22:37:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697033003/1
3 years, 10 months ago (2017-02-15 22:45:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-16 00:48:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697033003/1
3 years, 10 months ago (2017-02-16 00:51:39 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
3 years, 10 months ago (2017-02-16 02:16:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697033003/1
3 years, 10 months ago (2017-02-16 15:58:37 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 16:04:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33bb85e3541ce2b72da83dcd474d...

Powered by Google App Engine
This is Rietveld 408576698