[stubs] KeyedStoreGeneric: overwrite existing fast properties directly

[stubs] KeyedStoreGeneric: overwrite existing fast properties directly

Without relying on the stub cache.

Review-Url: https://codereview.chromium.org/2696993002
Cr-Commit-Position: refs/heads/master@{#43261}
Committed: https://chromium.googlesource.com/v8/v8/+/0393b11deab1a77716770d67c7009f7fc9f57f44

[Jakob Kummerow, 2017-02-15 19:22:22]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2017-02-15 19:22:23]

PTAL. 

We can probably re-use this code if/when we build a SetProperty stub in CSA.

[Jakob Kummerow, 2017-02-15 19:22:30]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 19:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 19:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 19:45:37]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-02-16 16:04:37]

nits:

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
File src/ic/keyed-store-generic.cc (right):

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
src/ic/keyed-store-generic.cc:631: }
CSA_ASSERT(representation == kTagged)?

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
src/ic/keyed-store-generic.cc:634: Bind(&r_smi);
1) "if (FLAG_track_fields) {" or we will have an unreachable block.
2) I think FLAG_track_fields must be made readonly or we could end up using stub
which is not in sync with the runtime code.

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
src/ic/keyed-store-generic.cc:637: Bind(&r_double);
Same here.

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
src/ic/keyed-store-generic.cc:649: Bind(&r_heapobject);
Same here.

[Jakob Kummerow, 2017-02-16 18:24:27]

Thanks, comments addressed.

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
File src/ic/keyed-store-generic.cc (right):

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
src/ic/keyed-store-generic.cc:631: }
On 2017/02/16 16:04:37, Igor Sheludko wrote:
> CSA_ASSERT(representation == kTagged)?

Done.

https://codereview.chromium.org/2696993002/diff/20001/src/ic/keyed-store-gene...
src/ic/keyed-store-generic.cc:634: Bind(&r_smi);
On 2017/02/16 16:04:37, Igor Sheludko wrote:
> 1) "if (FLAG_track_fields) {" or we will have an unreachable block.
> 2) I think FLAG_track_fields must be made readonly or we could end up using
stub
> which is not in sync with the runtime code.

I agree, but as discussed, that unfortunately doesn't work, because the snapshot
intentionally turns off FLAG_track_double_fields. To solve that issue, let's
just always emit all code here, regardless of flags.

[Igor Sheludko, 2017-02-16 19:10:20]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2017-02-16 19:10:21]

lgtm

[commit-bot: I haz the power, 2017-02-16 19:10:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:52:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487272220790910,
"parent_rev": "bd21c2bd043a0fd7ada8d721f88bb971ba5eb491", "commit_rev":
"0393b11deab1a77716770d67c7009f7fc9f57f44"}

[commit-bot: I haz the power, 2017-02-16 19:52:46]

Description was changed from

==========
[stubs] KeyedStoreGeneric: overwrite existing fast properties directly

Without relying on the stub cache.
==========

to

==========
[stubs] KeyedStoreGeneric: overwrite existing fast properties directly

Without relying on the stub cache.

Review-Url: https://codereview.chromium.org/2696993002
Cr-Commit-Position: refs/heads/master@{#43261}
Committed:
https://chromium.googlesource.com/v8/v8/+/0393b11deab1a77716770d67c7009f7fc9f...
==========

[commit-bot: I haz the power, 2017-02-16 19:52:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0393b11deab1a77716770d67c7009f7fc9f...