Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 2696973002: Allow Safe Browsing backend to select downloads to upload. (Closed)
Patch Set: Switch histogram to use enum, per isherman Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/download_feedback_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 98193c9658a2d49e527f74fefbb23d21344416ac..a8f8f84d96508cc24a27426ac2fed52744d36ede 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -3425,9 +3425,7 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, FeedbackServiceDiscardDownload) {
sb_service->download_protection_service();
download_protection_service->feedback_service()->MaybeStorePingsForDownload(
safe_browsing::DownloadProtectionService::UNCOMMON,
- downloads[0],
- ping_request,
- ping_response);
+ true /* upload_requested */, downloads[0], ping_request, ping_response);
ASSERT_TRUE(safe_browsing::DownloadFeedbackService::IsEnabledForDownload(
*(downloads[0])));
@@ -3478,8 +3476,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, FeedbackServiceKeepDownload) {
safe_browsing::DownloadProtectionService* download_protection_service =
sb_service->download_protection_service();
download_protection_service->feedback_service()->MaybeStorePingsForDownload(
- safe_browsing::DownloadProtectionService::UNCOMMON, downloads[0],
- ping_request, ping_response);
+ safe_browsing::DownloadProtectionService::UNCOMMON,
+ true /* upload_requested */, downloads[0], ping_request, ping_response);
ASSERT_TRUE(safe_browsing::DownloadFeedbackService::IsEnabledForDownload(
*(downloads[0])));
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/download_feedback_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698