Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4505)

Unified Diff: chrome/browser/safe_browsing/download_feedback_service.h

Issue 2696973002: Allow Safe Browsing backend to select downloads to upload. (Closed)
Patch Set: Switch histogram to use enum, per isherman Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_feedback_service.h
diff --git a/chrome/browser/safe_browsing/download_feedback_service.h b/chrome/browser/safe_browsing/download_feedback_service.h
index 474e4d80777f01e2549505834c546cc6235bcfa5..ae87ad3c238e6b201a26a1e79a29515cbad5f1ba 100644
--- a/chrome/browser/safe_browsing/download_feedback_service.h
+++ b/chrome/browser/safe_browsing/download_feedback_service.h
@@ -42,10 +42,13 @@ class DownloadFeedbackService {
// Stores the request and response ping data from the download check, if the
// check result and file size are eligible. This must be called after a
- // download has been flagged as malicious in order for the download to be
- // enabled for uploading.
+ // download has been flagged as un-SAFE in order for the download to be
+ // enabled for uploading. Some un-SAFE downloads can be marked for
+ // upload by the server with |upload_requested| if it's needed for better
+ // classification.
static void MaybeStorePingsForDownload(
DownloadProtectionService::DownloadCheckResult result,
+ bool upload_requested,
content::DownloadItem* download,
const std::string& ping,
const std::string& response);
« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/safe_browsing/download_feedback_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698