Split cursor location from UserDisplayManager.

Split cursor location from UserDisplayManager.

The code to manage shared cursor location isn't closely related to the
other functionality in UserDisplayManager. The biggest similarity is
that cursor location is on a per user basis. Move code into
CursorLocationManager to make UserDisplayManager easier to understand.

BUG=693081
Review-Url: https://codereview.chromium.org/2696963003
Cr-Commit-Position: refs/heads/master@{#451193}
Committed: https://chromium.googlesource.com/chromium/src/+/625c0cc94b7ee0441ac0debc5f295727f526eafd

[kylechar, 2017-02-16 19:27:15]

Description was changed from

==========
Split cursor location from UserDisplayManager.

The code to manage shared cursor location isn't closely related to the
other code in UserDisplayManager. Split code to make it clear what is
managed where.

BUG=
==========

to

==========
Split cursor location from UserDisplayManager.

The code to manage shared cursor location isn't closely related to the
other functionality in UserDisplayManager. The biggest similarity is
that cursor location is on a per user basis. Move code into
CursorLocationManager to make UserDisplayManager easier to understand.

BUG=693081
==========

[kylechar, 2017-02-16 19:30:08]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-02-16 19:30:47]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2017-02-16 21:19:49]

lgtm with nits

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/cursor_l...
File services/ui/ws/cursor_location_manager.h (right):

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/cursor_l...
services/ui/ws/cursor_location_manager.h:11: #include "ui/gfx/geometry/point.h"
nit: use a fwd decl instead

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/display_...
File services/ui/ws/display_manager.h (right):

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/display_...
services/ui/ws/display_manager.h:14: #include
"services/ui/ws/cursor_location_manager.h"
nit: use a fwd decl instead

[kylechar, 2017-02-16 22:06:56]

Thanks msw!

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/cursor_l...
File services/ui/ws/cursor_location_manager.h (right):

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/cursor_l...
services/ui/ws/cursor_location_manager.h:11: #include "ui/gfx/geometry/point.h"
On 2017/02/16 21:19:49, msw wrote:
> nit: use a fwd decl instead

Done.

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/display_...
File services/ui/ws/display_manager.h (right):

https://codereview.chromium.org/2696963003/diff/40001/services/ui/ws/display_...
services/ui/ws/display_manager.h:14: #include
"services/ui/ws/cursor_location_manager.h"
On 2017/02/16 21:19:49, msw wrote:
> nit: use a fwd decl instead

Done.

[kylechar, 2017-02-16 22:08:24]

Patchset #3 (id:60001) has been deleted

[kylechar, 2017-02-16 22:09:45]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 22:10:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-17 01:19:42]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-02-17 01:19:42]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-02-17 01:19:43]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2696963003/#ps80001
(title: "Fix nits.")

[commit-bot: I haz the power, 2017-02-17 01:20:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:36:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487294382928960,
"parent_rev": "e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48", "commit_rev":
"625c0cc94b7ee0441ac0debc5f295727f526eafd"}

[commit-bot: I haz the power, 2017-02-17 02:37:34]

Description was changed from

==========
Split cursor location from UserDisplayManager.

The code to manage shared cursor location isn't closely related to the
other functionality in UserDisplayManager. The biggest similarity is
that cursor location is on a per user basis. Move code into
CursorLocationManager to make UserDisplayManager easier to understand.

BUG=693081
==========

to

==========
Split cursor location from UserDisplayManager.

The code to manage shared cursor location isn't closely related to the
other functionality in UserDisplayManager. The biggest similarity is
that cursor location is on a per user basis. Move code into
CursorLocationManager to make UserDisplayManager easier to understand.

BUG=693081

Review-Url: https://codereview.chromium.org/2696963003
Cr-Commit-Position: refs/heads/master@{#451193}
Committed:
https://chromium.googlesource.com/chromium/src/+/625c0cc94b7ee0441ac0debc5f29...
==========

[commit-bot: I haz the power, 2017-02-17 02:37:35]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/625c0cc94b7ee0441ac0debc5f29...