Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2696953002: Fix missing dependencies in content/app. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing dependencies in content/app. These caused problems with generated mojo files, i.e. https://luci-milo.appspot.com/buildbot/chromium/Win/51874 and b/34895010 Review-Url: https://codereview.chromium.org/2696953002 Cr-Commit-Position: refs/heads/master@{#450772} Committed: https://chromium.googlesource.com/chromium/src/+/ce6dd211422093c0d556255b4275651b0da982fc

Patch Set 1 #

Patch Set 2 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M content/app/BUILD.gn View 1 7 chunks +31 lines, -7 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +16 lines, -10 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/utility/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jam
3 years, 10 months ago (2017-02-15 00:20:08 UTC) #8
brettw
lgtm
3 years, 10 months ago (2017-02-15 18:23:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696953002/20001
3 years, 10 months ago (2017-02-15 18:29:57 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:36:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce6dd211422093c0d556255b4275...

Powered by Google App Engine
This is Rietveld 408576698