chrome/browser/resources/settings/controls/settings_input.js - Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_input.js

Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior (Closed)

Patch Set: remove behavior from Settings controls that have indicators Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/controls/settings_input.js

diff --git a/chrome/browser/resources/settings/controls/settings_input.js b/chrome/browser/resources/settings/controls/settings_input.js

index 2652db1763bc0829117c9cedc4143789843170b0..0bee8236aab2bf402512288cf0fa9bf4bc7e9932 100644

--- a/chrome/browser/resources/settings/controls/settings_input.js

+++ b/chrome/browser/resources/settings/controls/settings_input.js

@@ -119,11 +119,10 @@ Polymer({

/**

* @param {boolean} disabled

- * @param {!chrome.settingsPrivate.PrefObject} pref

* @return {boolean} Whether the element should be disabled.

* @private

- isDisabled_: function(disabled, pref) {

- return disabled || this.isPrefPolicyControlled(pref);

+ isDisabled_: function(disabled) {

+ return disabled || this.isPrefPolicyControlled();

});