Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior

chrome/browser/resources/settings/controls/controlled_button.html

Index: chrome/browser/resources/settings/controls/controlled_button.html
diff --git a/chrome/browser/resources/settings/controls/controlled_button.html b/chrome/browser/resources/settings/controls/controlled_button.html
index 7f4e69d4bded78e4317fee1dea523a7e3220b356..8ace068c479cbf4183865e36244ec637c5561a44 100644
--- a/chrome/browser/resources/settings/controls/controlled_button.html
+++ b/chrome/browser/resources/settings/controls/controlled_button.html
@@ -1,7 +1,6 @@
 <link rel="import" href="chrome://resources/html/assert.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
-<link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_indicator_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_indicator.html">
 <link rel="import" href="pref_control_behavior.html">
@@ -43,7 +42,7 @@
       <content></content>
     </paper-button>
 
-    <template is="dom-if" if="[[showIndicator_(pref)]]" restamp>
+    <template is="dom-if" if="[[hasPolicy(pref.*)]]" restamp>

[stevenjb (google-dont-use), 2017/02/22 01:01:10]

Should this be [[indicatorVisible]]?

[michaelpg, 2017/02/22 21:00:01]

It amounts to the same thing, just from the other direction: an indicator is
visible iff its pref is policy-controlled.

hasPolicy() lets us wrap the indicator in a dom-if. It's an extra function, but
it lets us remove CrPolicyIndicatorBehavior from the control (since the
indicator already has that behavior anyway and makes all the same calculations).

       <cr-policy-pref-indicator pref="[[pref]]" on-tap="onIndicatorTap_">
       </cr-policy-pref-indicator>
     </template>