chrome/browser/resources/settings/controls/controlled_radio_button.js - Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/controlled_radio_button.js

Issue 2696903005: Move common cr-policy-indicator behavior into CrPolicyIndicatorBehavior (Closed)

Patch Set: remove behavior from Settings controls that have indicators Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/controlled_button.html ('K') | « chrome/browser/resources/settings/controls/controlled_radio_button.html ('k') | chrome/browser/resources/settings/controls/settings_boolean_control_behavior.html » ('j') | ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/controlled_radio_button.js

diff --git a/chrome/browser/resources/settings/controls/controlled_radio_button.js b/chrome/browser/resources/settings/controls/controlled_radio_button.js

index f6221e95fd488d71fbf3434e8761e698441a2d1a..39e5fbf1fbc703ce116c8a9da3350ab7c1f2ea92 100644

--- a/chrome/browser/resources/settings/controls/controlled_radio_button.js

+++ b/chrome/browser/resources/settings/controls/controlled_radio_button.js

@@ -36,12 +36,12 @@ Polymer({

/**

* @param {boolean} controlled

* @param {string} name

- * @param {chrome.settingsPrivate.PrefObject} pref

* @return {boolean}

* @private

- showIndicator_: function(controlled, name, pref) {

- return controlled && name == Settings.PrefUtil.prefToString(pref);

+ showIndicator_: function(controlled, name) {

+ return controlled &&

+ name == Settings.PrefUtil.prefToString(assert(this.pref));

/**