Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2696903004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, chromoting-reviews_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2696903004 Cr-Commit-Position: refs/heads/master@{#454081} Committed: https://chromium.googlesource.com/chromium/src/+/c7f36df401d6c79813e1137e4d67e0bb0ecf8557

Patch Set 1 #

Total comments: 23

Patch Set 2 : remove uncertain team #

Total comments: 6

Patch Set 3 : remove deleted file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/extensions/api/messaging/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/remoting/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/p2p/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/messaging/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M testing/chromoting/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-14 22:58:56 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/2696903004/diff/1/chrome/test/remoting/OWNERS File chrome/test/remoting/OWNERS (right): https://codereview.chromium.org/2696903004/diff/1/chrome/test/remoting/OWNERS#newcode9 chrome/test/remoting/OWNERS:9: # COMPONENT: Test>Missing This should be Services>Chromoting https://codereview.chromium.org/2696903004/diff/1/content/browser/renderer_host/p2p/OWNERS File ...
3 years, 10 months ago (2017-02-15 00:20:37 UTC) #3
ymzhang1
+Shruthi Regarding multiple components. https://codereview.chromium.org/2696903004/diff/1/chrome/test/remoting/OWNERS File chrome/test/remoting/OWNERS (right): https://codereview.chromium.org/2696903004/diff/1/chrome/test/remoting/OWNERS#newcode9 chrome/test/remoting/OWNERS:9: # COMPONENT: Test>Missing On 2017/02/15 ...
3 years, 10 months ago (2017-02-15 00:51:51 UTC) #5
ymzhang1
I have remove component information for those don't have a matched component. Thanks! https://codereview.chromium.org/2696903004/diff/1/jingle/OWNERS File ...
3 years, 10 months ago (2017-02-24 22:28:51 UTC) #6
Sergey Ulanov
https://codereview.chromium.org/2696903004/diff/40001/chrome/browser/extensions/api/messaging/OWNERS File chrome/browser/extensions/api/messaging/OWNERS (right): https://codereview.chromium.org/2696903004/diff/40001/chrome/browser/extensions/api/messaging/OWNERS#newcode9 chrome/browser/extensions/api/messaging/OWNERS:9: # COMPONENT: Blink>Messaging I'm not sure Blink>Messaging is related ...
3 years, 9 months ago (2017-02-27 21:30:01 UTC) #8
ymzhang1
https://codereview.chromium.org/2696903004/diff/40001/chrome/browser/extensions/api/messaging/OWNERS File chrome/browser/extensions/api/messaging/OWNERS (right): https://codereview.chromium.org/2696903004/diff/40001/chrome/browser/extensions/api/messaging/OWNERS#newcode9 chrome/browser/extensions/api/messaging/OWNERS:9: # COMPONENT: Blink>Messaging On 2017/02/27 21:30:01, Sergey Ulanov wrote: ...
3 years, 9 months ago (2017-02-28 00:35:20 UTC) #9
ymzhang1
Remove the deleted file third_party/libjingle/OWNERS.
3 years, 9 months ago (2017-02-28 18:41:13 UTC) #11
Sergey Ulanov
lgtm
3 years, 9 months ago (2017-03-01 22:21:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696903004/80001
3 years, 9 months ago (2017-03-01 22:23:22 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:58:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c7f36df401d6c79813e1137e4d67...

Powered by Google App Engine
This is Rietveld 408576698