Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2696903003: Gtk3: Fix memory leaks (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix memory leak, fix pseudoclasses on Gtk3.14 This CL * Fixes a GtkStyleContext leak * Ignores a leak caused by GtkStatusIcon * Fixes selectors that have a pseudoclass on a non-leaf widget such as "button:disabled label" on Gtk3.14. BUG=79722 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2696903003 Cr-Commit-Position: refs/heads/master@{#450518} Committed: https://chromium.googlesource.com/chromium/src/+/7acd31ee32e847f162438dee848f0d8c35936941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M chrome/browser/ui/libgtkui/gtk_status_icon.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom (Use chromium acct)
erg ptal This fixes the inactive menuitem text from yesterday. After this, I'll land the ...
3 years, 10 months ago (2017-02-14 22:12:47 UTC) #3
Elliot Glaysher
lgtm
3 years, 10 months ago (2017-02-14 22:25:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696903003/20001
3 years, 10 months ago (2017-02-14 23:28:26 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:59:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7acd31ee32e847f162438dee848f...

Powered by Google App Engine
This is Rietveld 408576698