Add video frames and volume tests

Add video frames and volume tests

BUG=680582, 680580
Review-Url: https://codereview.chromium.org/2696793003
Cr-Commit-Position: refs/heads/master@{#451167}
Committed: https://chromium.googlesource.com/chromium/src/+/55b05b671a67d43fa952494f7254fafa1b17bdaa

[Robert Ogden, 2017-02-14 17:25:13]

robertogden@chromium.org changed reviewers:
+ sclittle@chromium.org

[Robert Ogden, 2017-02-14 17:25:13]

Parts 1 and 2 out of 3 video integration tests.

[Tom Bergan, 2017-02-14 18:27:17]

tombergan@chromium.org changed reviewers:
+ tombergan@chromium.org

[Tom Bergan, 2017-02-14 18:27:18]

lgtm

lgtm with a few small comments. thanks!

https://codereview.chromium.org/2696793003/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/video.py (right):

https://codereview.chromium.org/2696793003/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/video.py:62: max_attempts = 10
Hopefully 10 attempts aren't actually necessary in practice! Do you have data on
how often this flakes?

https://codereview.chromium.org/2696793003/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/video.py:71:
self.assertHasChromeProxyViaHeader(resp)
Will this assertion fail (and crash the test) on a flake? If so, it's better to
move this just after line 74.

[Robert Ogden, 2017-02-14 18:57:32]

https://codereview.chromium.org/2696793003/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/video.py (right):

https://codereview.chromium.org/2696793003/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/video.py:62: max_attempts = 10
On 2017/02/14 18:27:18, Tom Bergan wrote:
> Hopefully 10 attempts aren't actually necessary in practice! Do you have data
on
> how often this flakes?

Of the numerous times I've run it on my machine, it typically needs no more than
2 but I've seen it only as high as 4.

https://codereview.chromium.org/2696793003/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/video.py:71:
self.assertHasChromeProxyViaHeader(resp)
On 2017/02/14 18:27:18, Tom Bergan wrote:
> Will this assertion fail (and crash the test) on a flake? If so, it's better
to
> move this just after line 74.

Done.

[Robert Ogden, 2017-02-16 21:31:46]

ping

[sclittle, 2017-02-16 21:38:12]

lgtm

[Robert Ogden, 2017-02-16 22:11:18]

The CQ bit was checked by robertogden@chromium.org

[Robert Ogden, 2017-02-16 22:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
tombergan@chromium.org
Link to the patchset: https://codereview.chromium.org/2696793003/#ps40001
(title: "Move via header assertion")

[commit-bot: I haz the power, 2017-02-16 22:12:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 01:26:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487283078237770,
"parent_rev": "3a6c5f97a4013fa27b9e5a47d71cee76c1513f35", "commit_rev":
"55b05b671a67d43fa952494f7254fafa1b17bdaa"}

[commit-bot: I haz the power, 2017-02-17 01:27:50]

Description was changed from

==========
Add video frames and volume tests

BUG=680582,680580
==========

to

==========
Add video frames and volume tests

BUG=680582,680580

Review-Url: https://codereview.chromium.org/2696793003
Cr-Commit-Position: refs/heads/master@{#451167}
Committed:
https://chromium.googlesource.com/chromium/src/+/55b05b671a67d43fa952494f7254...
==========

[commit-bot: I haz the power, 2017-02-17 01:27:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/55b05b671a67d43fa952494f7254...