Prepare CompositorFrameSinkSupport To Be Used By DirectCompositorFrameSink

Prepare CompositorFrameSinkSupport To Be Used By DirectCompositorFrameSink

Add handles_frame_sink_id_invalidation and need_sync_points flags to
CompositorFrameSinkSupport and its usages.

This CL is a subset of changes in 2612083002. It contains all the changes to
CompositorFrameSinkSupport that are needed for it to be used by
DirectCompositorFrameSink.

BUG=673543
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2696743002
Cr-Commit-Position: refs/heads/master@{#450473}
Committed: https://chromium.googlesource.com/chromium/src/+/f4a164c08e371b3d9948a078c5866b702eef6fd1

[Alex Z., 2017-02-13 22:22:18]

Description was changed from

==========
Prepare CompositorFrameSinkSupport To Be Used By DirectCompositorFrameSink

Add handles_frame_sink_id_invalidation and need_sync_points flags to
CompositorFrameSinkSupport and its usages.

This CL is a subset of changes in 2612083002. It contains all the changes to
CompositorFrameSinkSupport that are needed for it to be used by
DirectCompositorFrameSink.

BUG=673543
==========

to

==========
Prepare CompositorFrameSinkSupport To Be Used By DirectCompositorFrameSink

Add handles_frame_sink_id_invalidation and need_sync_points flags to
CompositorFrameSinkSupport and its usages.

This CL is a subset of changes in 2612083002. It contains all the changes to
CompositorFrameSinkSupport that are needed for it to be used by
DirectCompositorFrameSink.

BUG=673543
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Alex Z., 2017-02-13 22:22:27]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:23:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-02-13 22:24:37]

staraz@chromium.org changed reviewers:
+ danakj@chromium.org, reveman@chromium.org, xlai@chromium.org

[Alex Z., 2017-02-13 22:24:38]

xlai@chromium.org: Please review changes in offscreen canvas.

reveman@chromium.org: Please review changes in exo.

danakj@chromium.org: Please review changes in cc and 
components/display_compositor.

[commit-bot: I haz the power, 2017-02-13 22:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 22:53:15]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alex Z., 2017-02-13 23:31:35]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 23:33:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-02-13 23:36:20]

staraz@chromium.org changed reviewers:
+ boliu@chromium.org

[Alex Z., 2017-02-13 23:36:21]

boliu@chromium.org: Please review changes in android.

[commit-bot: I haz the power, 2017-02-13 23:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:58:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[boliu, 2017-02-14 00:00:03]

lgtm

https://codereview.chromium.org/2696743002/diff/20001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2696743002/diff/20001/content/renderer/androi...
content/renderer/android/synchronous_compositor_frame_sink.cc:171: const bool
root_submits_to_display_compositor = true;
nit: constexpr for all these

[Alex Z., 2017-02-14 02:13:17]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-02-14 02:13:33]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-14 02:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 04:38:57]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-02-14 16:54:01]

LGTM

https://codereview.chromium.org/2696743002/diff/40001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2696743002/diff/40001/content/renderer/androi...
content/renderer/android/synchronous_compositor_frame_sink.cc:171: const bool
root_submits_to_display_compositor = true;
We were talking about names with fsamuel the other day and he mentioned that
this concept of "offscreen" really means "not-root". I wonder if that applies
here too.. in that children also submit frames to a display compositor too
right? They are just not the root of the display compositor. So I wonder if
these should be named in those terms (root vs child)?

[xlai (Olivia), 2017-02-14 16:56:29]

lgtm

[reveman, 2017-02-14 17:06:20]

components/exo lgtm

[Alex Z., 2017-02-14 19:58:17]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-02-14 19:58:17]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
danakj@chromium.org, xlai@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2696743002/#ps60001
(title: "Rename submits_to_display_compositor_ to is_root_")

[Alex Z., 2017-02-14 19:58:30]

On 2017/02/14 00:00:03, boliu wrote:
> lgtm
> 
>
https://codereview.chromium.org/2696743002/diff/20001/content/renderer/androi...
> File content/renderer/android/synchronous_compositor_frame_sink.cc (right):
> 
>
https://codereview.chromium.org/2696743002/diff/20001/content/renderer/androi...
> content/renderer/android/synchronous_compositor_frame_sink.cc:171: const bool
> root_submits_to_display_compositor = true;
> nit: constexpr for all these

Done.

[commit-bot: I haz the power, 2017-02-14 19:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-02-14 19:59:02]

On 2017/02/14 16:54:01, danakj wrote:
> LGTM
> 
>
https://codereview.chromium.org/2696743002/diff/40001/content/renderer/androi...
> File content/renderer/android/synchronous_compositor_frame_sink.cc (right):
> 
>
https://codereview.chromium.org/2696743002/diff/40001/content/renderer/androi...
> content/renderer/android/synchronous_compositor_frame_sink.cc:171: const bool
> root_submits_to_display_compositor = true;
> We were talking about names with fsamuel the other day and he mentioned that
> this concept of "offscreen" really means "not-root". I wonder if that applies
> here too.. in that children also submit frames to a display compositor too
> right? They are just not the root of the display compositor. So I wonder if
> these should be named in those terms (root vs child)?

submits_to_display_compositor_ has been renamed to is_root_.

[commit-bot: I haz the power, 2017-02-14 21:10:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487102297513770,
"parent_rev": "8aca6ce1196fca0dc0cca083b24be9b483f0dc3d", "commit_rev":
"f4a164c08e371b3d9948a078c5866b702eef6fd1"}

[commit-bot: I haz the power, 2017-02-14 21:11:22]

Description was changed from

==========
Prepare CompositorFrameSinkSupport To Be Used By DirectCompositorFrameSink

Add handles_frame_sink_id_invalidation and need_sync_points flags to
CompositorFrameSinkSupport and its usages.

This CL is a subset of changes in 2612083002. It contains all the changes to
CompositorFrameSinkSupport that are needed for it to be used by
DirectCompositorFrameSink.

BUG=673543
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Prepare CompositorFrameSinkSupport To Be Used By DirectCompositorFrameSink

Add handles_frame_sink_id_invalidation and need_sync_points flags to
CompositorFrameSinkSupport and its usages.

This CL is a subset of changes in 2612083002. It contains all the changes to
CompositorFrameSinkSupport that are needed for it to be used by
DirectCompositorFrameSink.

BUG=673543
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2696743002
Cr-Commit-Position: refs/heads/master@{#450473}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4a164c08e371b3d9948a078c586...
==========

[commit-bot: I haz the power, 2017-02-14 21:11:27]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f4a164c08e371b3d9948a078c586...