Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: pkg/polymer/lib/src/build/script_compactor.dart

Issue 26967004: add @MirrorsUsed to observe/polymer/polymer_exprs pkgs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix typo in comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/build/script_compactor.dart
diff --git a/pkg/polymer/lib/src/build/script_compactor.dart b/pkg/polymer/lib/src/build/script_compactor.dart
index a20fcd619f267357b3e7b8f25eb95f843a0f74c2..0b4ffcadad16c0d4b42d4a29799d6df04a62e41e 100644
--- a/pkg/polymer/lib/src/build/script_compactor.dart
+++ b/pkg/polymer/lib/src/build/script_compactor.dart
@@ -93,7 +93,7 @@ class ScriptCompactor extends Transformer with PolymerTransformer {
var urls = libraries.map((id) => assetUrlFor(id, bootstrapId, logger))
.where((url) => url != null).toList();
- var buffer = new StringBuffer()..write(_header);
+ var buffer = new StringBuffer()..writeln(MAIN_HEADER);
for (int i = 0; i < urls.length; i++) {
buffer.writeln("import '${urls[i]}' as i$i;");
}
@@ -107,12 +107,12 @@ class ScriptCompactor extends Transformer with PolymerTransformer {
}
}
-const _header = """
+const MAIN_HEADER = """
library app_bootstrap;
import 'package:polymer/polymer.dart';
-import 'dart:mirrors' show currentMirrorSystem;
-
+@MirrorsUsed(symbols: 'main', override: 'app_bootstrap')
Siggi Cherem (dart-lang) 2013/10/15 21:52:18 same here, remove override?
Jennifer Messerly 2013/10/15 22:03:29 I'd prefer not to, otherwise we risk breaking mirr
+import 'dart:mirrors' show currentMirrorSystem, MirrorsUsed;
""";
const _mainPrefix = """

Powered by Google App Engine
This is Rietveld 408576698