Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: pkg/polymer/lib/polymer.dart

Issue 26967004: add @MirrorsUsed to observe/polymer/polymer_exprs pkgs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix typo in comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/polymer.dart
diff --git a/pkg/polymer/lib/polymer.dart b/pkg/polymer/lib/polymer.dart
index 34cc161f6bf024ba7b61e3c4711aedbe85ab4bdb..f763cfdb757a6d3fcd7d5b5feb61df62a595779a 100644
--- a/pkg/polymer/lib/polymer.dart
+++ b/pkg/polymer/lib/polymer.dart
@@ -43,6 +43,10 @@ import 'dart:async';
import 'dart:collection' show HashMap;
import 'dart:html';
import 'dart:js' as js;
+
+@MirrorsUsed(metaTargets:
+ const [Reflectable, ObservableProperty, CustomTag, 'initMethod'],
Siggi Cherem (dart-lang) 2013/10/15 21:52:18 ohhh, so dart2js is smart about understanding that
Siggi Cherem (dart-lang) 2013/10/15 21:52:18 About 'initMethod', should this be 'initMethod' or
Jennifer Messerly 2013/10/15 22:03:29 yup
Jennifer Messerly 2013/10/15 22:03:29 originally I was having issues with private types.
+ override: const ['polymer', 'polymer.deserialize'])
Siggi Cherem (dart-lang) 2013/10/15 21:52:18 Q: I wonder if the override should just be '*' so
Jennifer Messerly 2013/10/15 22:03:29 exactly. Building "*" into Polymer would be bad :)
import 'dart:mirrors';
import 'package:logging/logging.dart' show Logger, Level;
@@ -58,6 +62,7 @@ import 'package:polymer_expressions/polymer_expressions.dart'
import 'deserialize.dart' as deserialize;
import 'job.dart';
import 'platform.dart' as platform;
+import 'src/reflected_type.dart';
export 'package:observe/observe.dart';
export 'package:observe/html.dart';

Powered by Google App Engine
This is Rietveld 408576698