Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2696653002:
Add TEAM/COMPONENT (Closed)
|
Created:
3 years, 10 months ago by ymzhang1 Modified:
3 years, 10 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tdresser+watch_chromium.org, wfh+watch_chromium.org, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, tracing+reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.
We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.
Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping
Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents
BUG=679905
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2696653002
Cr-Commit-Position: refs/heads/master@{#451108}
Committed: https://chromium.googlesource.com/chromium/src/+/5f69b522ecd35baddebd319fe287f97c9500d5fd
Patch Set 1 #
Total comments: 7
Patch Set 2 : update component #Patch Set 3 : remove unverified file #Patch Set 4 : remove unverified file #
Messages
Total messages: 51 (31 generated)
Description was changed from ========== Add TEAM/COMPONENT BUG=679905 ========== to ========== Add TEAM/COMPONENT BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ymzhang@chromium.org changed reviewers: + jbauman@chromium.org, sadrul@chromium.org
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files? Thank you very much!
danakj@chromium.org changed reviewers: + danakj@chromium.org
> Add TEAM/COMPONENT Drive-by: please write more information as your change description. You put a lot of info in a comment instead of into the description. See go/cl-descriptions
Description was changed from ========== Add TEAM/COMPONENT BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add TEAM/COMPONENT BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
danakj@chromium.org changed reviewers: - danakj@chromium.org
Description was changed from ========== Add TEAM/COMPONENT BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/02/13 19:19:31, danakj wrote: > > Add TEAM/COMPONENT > > > Drive-by: please write more information as your change description. You put a > lot of info in a comment instead of into the description. See go/cl-descriptions Thanks for the suggestion. Updated the description.
On 2017/02/13 19:30:31, ymzhang1 wrote: > On 2017/02/13 19:19:31, danakj wrote: > > > Add TEAM/COMPONENT > > > > > > Drive-by: please write more information as your change description. You put a > > lot of info in a comment instead of into the description. See > go/cl-descriptions > > Thanks for the suggestion. Updated the description. drive-by: please use 80 characters per line if possible. And I guess the format you want would be: CL summary CL description BUG=679905
On 2017/02/13 19:40:27, lpy wrote: > On 2017/02/13 19:30:31, ymzhang1 wrote: > > On 2017/02/13 19:19:31, danakj wrote: > > > > Add TEAM/COMPONENT > > > > > > > > > Drive-by: please write more information as your change description. You put > a > > > lot of info in a comment instead of into the description. See > > go/cl-descriptions > > > > Thanks for the suggestion. Updated the description. > > drive-by: please use 80 characters per line if possible. And I guess the format > you want would be: > > CL summary > > CL description > > BUG=679905 Another drive-by: there is a doc that explains the team and component concepts and why we are doing this, why not link to it? https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...
Description was changed from ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/02/13 19:45:12, sullivan wrote: > On 2017/02/13 19:40:27, lpy wrote: > > On 2017/02/13 19:30:31, ymzhang1 wrote: > > > On 2017/02/13 19:19:31, danakj wrote: > > > > > Add TEAM/COMPONENT > > > > > > > > > > > > Drive-by: please write more information as your change description. You > put > > a > > > > lot of info in a comment instead of into the description. See > > > go/cl-descriptions > > > > > > Thanks for the suggestion. Updated the description. > > > > drive-by: please use 80 characters per line if possible. And I guess the > format > > you want would be: > > > > CL summary > > > > CL description > > > > BUG=679905 > > Another drive-by: there is a doc that explains the team and component concepts > and why we are doing this, why not link to it? > https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Thanks a lot for suggestion! Updated as suggested. Also put the links to the doc that explain how to get suggested component and current collected team-component mapping. Hope now it looks better.
On 2017/02/13 21:26:24, ymzhang1 wrote: > On 2017/02/13 19:45:12, sullivan wrote: > > On 2017/02/13 19:40:27, lpy wrote: > > > On 2017/02/13 19:30:31, ymzhang1 wrote: > > > > On 2017/02/13 19:19:31, danakj wrote: > > > > > > Add TEAM/COMPONENT > > > > > > > > > > > > > > > Drive-by: please write more information as your change description. You > > put > > > a > > > > > lot of info in a comment instead of into the description. See > > > > go/cl-descriptions > > > > > > > > Thanks for the suggestion. Updated the description. > > > > > > drive-by: please use 80 characters per line if possible. And I guess the > > format > > > you want would be: > > > > > > CL summary > > > > > > CL description > > > > > > BUG=679905 > > > > Another drive-by: there is a doc that explains the team and component concepts > > and why we are doing this, why not link to it? > > > https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... > > Thanks a lot for suggestion! Updated as suggested. Also put the links to the doc > that explain how to get suggested component and current collected team-component > mapping. Hope now it looks better. I think you missed lpy's feedback about line lengths and ordering?
Description was changed from ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCSTh0/ edit#heading=h.xgjl2srtytjt Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCSTh0/ edit#heading=h.xgjl2srtytjt Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/02/13 21:30:27, sullivan wrote: > On 2017/02/13 21:26:24, ymzhang1 wrote: > > On 2017/02/13 19:45:12, sullivan wrote: > > > On 2017/02/13 19:40:27, lpy wrote: > > > > On 2017/02/13 19:30:31, ymzhang1 wrote: > > > > > On 2017/02/13 19:19:31, danakj wrote: > > > > > > > Add TEAM/COMPONENT > > > > > > > > > > > > > > > > > > Drive-by: please write more information as your change description. > You > > > put > > > > a > > > > > > lot of info in a comment instead of into the description. See > > > > > go/cl-descriptions > > > > > > > > > > Thanks for the suggestion. Updated the description. > > > > > > > > drive-by: please use 80 characters per line if possible. And I guess the > > > format > > > > you want would be: > > > > > > > > CL summary > > > > > > > > CL description > > > > > > > > BUG=679905 > > > > > > Another drive-by: there is a doc that explains the team and component > concepts > > > and why we are doing this, why not link to it? > > > > > > https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... > > > > Thanks a lot for suggestion! Updated as suggested. Also put the links to the > doc > > that explain how to get suggested component and current collected > team-component > > mapping. Hope now it looks better. > > I think you missed lpy's feedback about line lengths and ordering? Oh, my bad. Thanks for pointing out! (Sorry, I haven't figured out how to split the link url use 80 characters per line.)
On 2017/02/13 22:50:22, ymzhang1 wrote: > On 2017/02/13 21:30:27, sullivan wrote: > > On 2017/02/13 21:26:24, ymzhang1 wrote: > > > On 2017/02/13 19:45:12, sullivan wrote: > > > > On 2017/02/13 19:40:27, lpy wrote: > > > > > On 2017/02/13 19:30:31, ymzhang1 wrote: > > > > > > On 2017/02/13 19:19:31, danakj wrote: > > > > > > > > Add TEAM/COMPONENT > > > > > > > > > > > > > > > > > > > > > Drive-by: please write more information as your change description. > > You > > > > put > > > > > a > > > > > > > lot of info in a comment instead of into the description. See > > > > > > go/cl-descriptions > > > > > > > > > > > > Thanks for the suggestion. Updated the description. > > > > > > > > > > drive-by: please use 80 characters per line if possible. And I guess the > > > > format > > > > > you want would be: > > > > > > > > > > CL summary > > > > > > > > > > CL description > > > > > > > > > > BUG=679905 > > > > > > > > Another drive-by: there is a doc that explains the team and component > > concepts > > > > and why we are doing this, why not link to it? > > > > > > > > > > https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... > > > > > > Thanks a lot for suggestion! Updated as suggested. Also put the links to the > > doc > > > that explain how to get suggested component and current collected > > team-component > > > mapping. Hope now it looks better. > > > > I think you missed lpy's feedback about line lengths and ordering? > > Oh, my bad. Thanks for pointing out! > (Sorry, I haven't figured out how to split the link url use 80 characters per > line.) Maybe use a bit.ly link with a friendly name like "bit.ly/team-components-proposal"?
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/02/13 22:54:54, sullivan wrote: > On 2017/02/13 22:50:22, ymzhang1 wrote: > > On 2017/02/13 21:30:27, sullivan wrote: > > > On 2017/02/13 21:26:24, ymzhang1 wrote: > > > > On 2017/02/13 19:45:12, sullivan wrote: > > > > > On 2017/02/13 19:40:27, lpy wrote: > > > > > > On 2017/02/13 19:30:31, ymzhang1 wrote: > > > > > > > On 2017/02/13 19:19:31, danakj wrote: > > > > > > > > > Add TEAM/COMPONENT > > > > > > > > > > > > > > > > > > > > > > > > Drive-by: please write more information as your change > description. > > > You > > > > > put > > > > > > a > > > > > > > > lot of info in a comment instead of into the description. See > > > > > > > go/cl-descriptions > > > > > > > > > > > > > > Thanks for the suggestion. Updated the description. > > > > > > > > > > > > drive-by: please use 80 characters per line if possible. And I guess > the > > > > > format > > > > > > you want would be: > > > > > > > > > > > > CL summary > > > > > > > > > > > > CL description > > > > > > > > > > > > BUG=679905 > > > > > > > > > > Another drive-by: there is a doc that explains the team and component > > > concepts > > > > > and why we are doing this, why not link to it? > > > > > > > > > > > > > > > https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... > > > > > > > > Thanks a lot for suggestion! Updated as suggested. Also put the links to > the > > > doc > > > > that explain how to get suggested component and current collected > > > team-component > > > > mapping. Hope now it looks better. > > > > > > I think you missed lpy's feedback about line lengths and ordering? > > > > Oh, my bad. Thanks for pointing out! > > (Sorry, I haven't figured out how to split the link url use 80 characters per > > line.) > > Maybe use a bit.ly link with a friendly name like > "bit.ly/team-components-proposal"? wow, so cool! Thanks!
jbauman@chromium.org changed reviewers: + danakj@chromium.org
https://codereview.chromium.org/2696653002/diff/1/components/display_composit... File components/display_compositor/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/components/display_composit... components/display_compositor/OWNERS:6: # COMPONENT: OS>Kernel>Display I think this is should be Internals>Compositing. https://codereview.chromium.org/2696653002/diff/1/content/browser/compositor/... File content/browser/compositor/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/content/browser/compositor/... content/browser/compositor/OWNERS:9: # COMPONENT: UI>Browser danakj: Thoughts on where this should go? I'm torn between this and Internals>Compositing. https://codereview.chromium.org/2696653002/diff/1/ui/gl/OWNERS File ui/gl/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/ui/gl/OWNERS#newcode9 ui/gl/OWNERS:9: # COMPONENT: UI I think Internals>GPU for this
primiano@chromium.org changed reviewers: + primiano@chromium.org
components/tracing/ LGTM
https://codereview.chromium.org/2696653002/diff/1/content/browser/compositor/... File content/browser/compositor/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/content/browser/compositor/... content/browser/compositor/OWNERS:9: # COMPONENT: UI>Browser On 2017/02/13 23:42:32, jbauman wrote: > danakj: Thoughts on where this should go? I'm torn between this and > Internals>Compositing. I think Compositing, I don't think any UI>Browser owners work in here (I don't know who they are)?
https://codereview.chromium.org/2696653002/diff/1/components/display_composit... File components/display_compositor/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/components/display_composit... components/display_compositor/OWNERS:6: # COMPONENT: OS>Kernel>Display On 2017/02/13 23:42:32, jbauman wrote: > I think this is should be Internals>Compositing. Done. https://codereview.chromium.org/2696653002/diff/1/content/browser/compositor/... File content/browser/compositor/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/content/browser/compositor/... content/browser/compositor/OWNERS:9: # COMPONENT: UI>Browser On 2017/02/14 15:46:13, danakj wrote: > On 2017/02/13 23:42:32, jbauman wrote: > > danakj: Thoughts on where this should go? I'm torn between this and > > Internals>Compositing. > > I think Compositing, I don't think any UI>Browser owners work in here (I don't > know who they are)? Internals>Compositing? https://codereview.chromium.org/2696653002/diff/1/ui/gl/OWNERS File ui/gl/OWNERS (right): https://codereview.chromium.org/2696653002/diff/1/ui/gl/OWNERS#newcode9 ui/gl/OWNERS:9: # COMPONENT: UI On 2017/02/13 23:42:32, jbauman wrote: > I think Internals>GPU for this Done.
On Tue, Feb 14, 2017 at 1:50 PM, <ymzhang@chromium.org> wrote: > > https://codereview.chromium.org/2696653002/diff/1/ > components/display_compositor/OWNERS > File components/display_compositor/OWNERS (right): > > https://codereview.chromium.org/2696653002/diff/1/ > components/display_compositor/OWNERS#newcode6 > components/display_compositor/OWNERS:6: # COMPONENT: OS>Kernel>Display > On 2017/02/13 23:42:32, jbauman wrote: > > I think this is should be Internals>Compositing. > > Done. > > https://codereview.chromium.org/2696653002/diff/1/content/ > browser/compositor/OWNERS > File content/browser/compositor/OWNERS (right): > > https://codereview.chromium.org/2696653002/diff/1/content/ > browser/compositor/OWNERS#newcode9 > content/browser/compositor/OWNERS:9: # COMPONENT: UI>Browser > On 2017/02/14 15:46:13, danakj wrote: > > On 2017/02/13 23:42:32, jbauman wrote: > > > danakj: Thoughts on where this should go? I'm torn between this and > > > Internals>Compositing. > > > > I think Compositing, I don't think any UI>Browser owners work in here > (I don't > > know who they are)? > > Internals>Compositing? > Ya sorry thats what I meant > > > https://codereview.chromium.org/2696653002/diff/1/ui/gl/OWNERS > File ui/gl/OWNERS (right): > > https://codereview.chromium.org/2696653002/diff/1/ui/gl/OWNERS#newcode9 > ui/gl/OWNERS:9: # COMPONENT: UI > On 2017/02/13 23:42:32, jbauman wrote: > > I think Internals>GPU for this > > Done. > > https://codereview.chromium.org/2696653002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by ymzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org Link to the patchset: https://codereview.chromium.org/2696653002/#ps20001 (title: "update component")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by ymzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, jbauman@chromium.org Link to the patchset: https://codereview.chromium.org/2696653002/#ps60001 (title: "remove unverified file")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487278724668150,
"parent_rev": "7236fb9312cfeb76d7f0c195eb567c995143add5", "commit_rev":
"5f69b522ecd35baddebd319fe287f97c9500d5fd"}
Message was sent while issue was closed.
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696653002 Cr-Commit-Position: refs/heads/master@{#451108} Committed: https://chromium.googlesource.com/chromium/src/+/5f69b522ecd35baddebd319fe287... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5f69b522ecd35baddebd319fe287... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
